Add octave shift example#110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 2 2
Lines 344 344
=======================================
Hits 335 335
Misses 9 9 Continue to review full report at Codecov.
|
|
Wow, this looks great! It would good to have it only run for a specific amount of time, so we can eventually run it in CI. The pattern I've used in #107 was There might be better ways to do this. |
|
PS, do you want to join as a maintainer? |
Yes, I would be happy to help in that way. I don't know anything about libportaudio but can help on the Julia side. Thanks! |
|
Ok, I implemented the suggested I might slightly prefer that way, because it will look less mysterious to beginnners. |
Nope, whatever works! |
|
Ok, I went with the loop approach and added a bit more documentation and now it is ready for review. |
|
This looks good to me! |
1 similar comment
|
This looks good to me! |
This PR provides an example of performing a real-time octave (down) shift using a crude FFT approach.
I did not see any examples that show audio processing of an input stream and writing the results to an output stream and I wanted to have an illustration of that for students in my course.
This is independent of #107 though of course they both work on the examples/ directory.