chore: move CI and the image build to Node 24 LTS - #57
Merged
Conversation
Node 20 reached the end of its life and GitHub's runners now warn on actions that declare a node20 runtime. Separately, CI built and tested the frontend on Node 20 while the Docker image built it on Node 22, so the version validated in CI was never the version shipped. Move everything to Node 24, the current active LTS (Node 22 dropped to maintenance in October 2025): - lint.yml and release.yml: node-version 20 -> 24. - Dockerfile: node:22-slim -> node:24-slim, so the image builds the SPA on the same version CI tests it on. - Bump every action one major to its node24 runtime, re-resolving the pinned SHAs in docker-publish.yml: checkout v5.1.0, setup-qemu v4.2.0, setup-buildx v4.3.0, login v4.6.0, metadata v6.2.0, build-push v7.3.0, plus setup-python v6, setup-node v5 and action-gh-release v3. Verified against node:24-slim: tsc -b and eslint are clean, all 169 frontend tests pass, and the image builds. The resulting image digest is byte-identical to the Node 22 build, so the toolchain moves without changing the shipped artifact.
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gives nvm, fnm and asdf users the same Node version CI and the Docker image build use, so `nvm use` in src/frontend matches what the SPA is actually tested and built on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two separate Node problems, both fixed by landing on the same version.
Node 20 is end-of-life. GitHub's runners now emit a deprecation warning
for every action declaring a
node20runtime, and already execute them onNode 24 via a compatibility shim that will eventually go away.
CI and the image disagreed.
lint.ymlandrelease.ymlbuilt andtested the frontend on Node 20, while the Dockerfile built that same
frontend on Node 22. The version validated in CI was never the version
shipped.
What
Node 24 is the current active LTS; Node 22 dropped to maintenance in
October 2025.
Project Node
lint.ymlnode-version: '20''24'release.yml(×2)node-version: '20''24'Dockerfilenode:22-slimnode:24-slimThe Dockerfile is included on purpose — leaving it on 22 would just
recreate the tested-on-X / shipped-on-Y split this PR exists to close.
Local development
Adds
src/frontend/.nvmrcpinning24, sonvm use(or fnm/asdf) in thefrontend directory gives contributors the same Node the CI and the image
build use.
Action runtimes
Every action bumped one major to its
node24runtime. The pinned SHAs indocker-publish.ymlwere re-resolved;lint.ymlandrelease.ymlkeeptheir existing unpinned-tag style.
actions/checkoutdocker/setup-qemu-actiondocker/setup-buildx-actiondocker/login-actiondocker/metadata-actiondocker/build-push-actionactions/setup-pythonactions/setup-nodesoftprops/action-gh-releaseTesting
Ran the full frontend suite inside
node:24-slim(v24.19.0):tsc -bcleaneslint .cleanvite buildsucceedsThe image builds, and its digest comes out byte-identical to the Node
22 build — confirmed not to be a stale cache by checking
node -vinsidethe builder stage. The toolchain moves without changing the shipped
artifact.
Not covered by local testing
release.ymlonly fires onv*.*.*tags, so thesoftprops/action-gh-releasev2→v3 bump is unexercised until the nextrelease tag. The inputs this repo uses (
files,generate_release_notes)are unchanged in v3.