Skip to content

Update hack-manager.js#20

Open
ofaolin wants to merge 3 commits into
Jrpl:mainfrom
ofaolin:patch-3
Open

Update hack-manager.js#20
ofaolin wants to merge 3 commits into
Jrpl:mainfrom
ofaolin:patch-3

Conversation

@ofaolin

@ofaolin ofaolin commented Feb 20, 2024

Copy link
Copy Markdown

fix thread floating point error
tweak scp to copy from current server other than home

fix thread floating point error
tweak scp to copy from current server other than home
@Jrpl Jrpl self-requested a review May 13, 2024 02:41
@Jrpl

Jrpl commented May 13, 2024

Copy link
Copy Markdown
Owner

I don't actively work on this repo anymore so I'm going to implicitly trust this works. Would this fix this issue? #22

@PossumZeus PossumZeus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make these exact changes locally to fix it too, I approve

@kylechallis

Copy link
Copy Markdown

I don't actively work on this repo anymore so I'm going to implicitly trust this works. Would this fix this issue? #22

Yes, these changes fix #22

@emirdero

emirdero commented Jul 28, 2024

Copy link
Copy Markdown

@Jrpl Please merge these changes, it will help others like me from debugging the code themselves

@bmentges

Copy link
Copy Markdown

I just reviewed this PR, integrating it on my gameplay. It fixed the remote scripts and also the math.floor issues when calculating threads.

I recommend this to be merged because the current file on master is not working on the parts this PR fixed:

  • scp had the arguments out of order. ns.scp(file, destination, source) is the correct one, with source being optional. This PR fixes it.
  • several math.floor missing on thread calculation/usage leading to crash. This PR fixes it.

@bmentges bmentges left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the file usable. Recommend merging.

@bmentges

Copy link
Copy Markdown

For those wanting a working orchestrator, check out my take on it for Bitburner v2.8.1: https://github.com/bmentges/bitburner-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants