ci(deploy-preview): preview when the pins that drive rendering change - #33
Merged
Conversation
The trigger watched platform/** only, but schema-version and context-ref live in deploy-preview.yml itself and decide whether rendering works at all. A pin bump therefore merged with no readiness preview: today's bump PRs ran workflow lint, hygiene and the language CI jobs, and no Deploy Validate. That is how github-workflows v0.15.0 reached every service repository. It carried a context-resolution bug that failed all five fragment renders, and every PR pinning it merged without attempting one; the bug surfaced later on an unrelated PR that happened to touch platform/. The workflow file joins the filter so a render is attempted whenever the pins move. This does not make the scorecard block a merge -- the only required check is Pipeline Complete, which aggregates ci.yml jobs and not this workflow.
Deploy Preview — knowledgeEnvironments: production Image refs
SC-11 Readiness Scorecard
Updated by deploy-check on push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-previewtriggers onpaths: ['platform/**']. The values that decide whether rendering works at all —schema-versionandcontext-ref— live indeploy-preview.ymlitself, which that filter does not cover.So a pin bump merges with no readiness preview. Today's pin-bump PRs show it: their check list contains
Workflow Lint,Repository Hygiene Guard, the language CI jobs — and noDeploy Validate.That is not hypothetical.
github-workflowsv0.15.0 shipped with a context-resolution bug that made all five fragment renders fail, and the PRs that pinned it to every service repo were merged without a single render being attempted. The bug surfaced only on the next PR that happened to touchplatform/.Change
The toolkit compares its own version against the context's
schemaVersionwith strict equality, so a mismatched pair fails loudly at render time — but only if a render is attempted. This makes it attempted whenever the pins move.Scope and limits
This does not make the scorecard block a merge. The only required check in the ruleset is
Pipeline Complete, which aggregates sixci.ymljobs;deploy-previewis a separate workflow and is not among them, so it stays advisory.Making it required is not a one-line change either: a paths-filtered check never reports on PRs that do not match, and GitHub treats a required-but-absent check as permanently pending, which would deadlock every unrelated PR. Getting there means having the workflow always trigger and report success when there is nothing to render — a deliberate change to merge gating across seven repositories, which belongs in its own decision rather than bundled here.