feat(platform): declare the ingest worker exempt from the health check - #30
Merged
Conversation
knowledge-ingest-worker is a RabbitMQ consumer. Its cluster manifest declares no ports and no readiness or liveness probe, so there is no HTTP surface to probe, and the SC-11 health_declared check -- which requires a health.path from every workload -- could not be satisfied for this deployment. health.mandatory: false records that deliberately. The check now reports pass and names the exemption in its detail column, so the decision stays visible on every preview rather than being inferred from an absent field. Omitting health altogether is still a failure, which keeps an oversight distinguishable from a decision. The rendered output is byte-identical before and after: diff -rq over both out/manifests and out/apply reports no differences, and the worker still renders with no probes. This is a declaration change with no deployment impact. github-workflows pins move to v0.16.0, which is where the check honours the field and where a pin selects the action code that runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knowledge-ingest-workeris a RabbitMQ consumer. Its cluster manifest declares noportsand noreadinessProbe/livenessProbe— there is no HTTP surface to probe. The SC-11health_declaredcheck requires ahealth.pathfrom every workload, so it could not be satisfied for this deployment; it reported a barefailwith nothing actionable behind it.This repository has no
deploy-previewworkflow, so the scorecard had never been evaluated against thisdeployment.ymland the gap went unreported until the shared checker was run here.Change
The check now reports:
The exemption stays visible on every preview instead of being inferred from an absent field. Omitting
healthaltogether is still a failure (JorisJonkers-dev/github-workflows#100), so an oversight remains distinguishable from a decision.No deployment impact
diff -rqover bothout/manifestsandout/apply, rendered before and after the change, reports no differences. The worker still renders with no probes.health.mandatorywas already in the deployment schema and previously unused.Pins
github-workflowsmoves to v0.16.0 — the release where the check honours this field, and where a pin actually selects the action code that runs (until v0.15.2, an emptyjob_workflow_shameant every consumer ranmainregardless of its pin).