Skip to content

feat(platform): declare the ingest worker exempt from the health check - #30

Merged
ExtraToast merged 1 commit into
mainfrom
feat/exempt-worker-health
Aug 20, 2026
Merged

feat(platform): declare the ingest worker exempt from the health check#30
ExtraToast merged 1 commit into
mainfrom
feat/exempt-worker-health

Conversation

@ExtraToast

Copy link
Copy Markdown
Contributor

knowledge-ingest-worker is a RabbitMQ consumer. Its cluster manifest declares no ports and no readinessProbe/livenessProbe — there is no HTTP surface to probe. The SC-11 health_declared check requires a health.path from every workload, so it could not be satisfied for this deployment; it reported a bare fail with nothing actionable behind it.

This repository has no deploy-preview workflow, so the scorecard had never been evaluated against this deployment.yml and the gap went unreported until the shared checker was run here.

Change

- name: knowledge-ingest-worker
  # A RabbitMQ consumer with no HTTP surface: its cluster manifest declares
  # no ports and no probes, so there is nothing to probe. mandatory: false
  # records that deliberately, rather than leaving health undeclared and
  # indistinguishable from an oversight.
  health:
    mandatory: false

The check now reports:

| ✅ | health_declared | pass | exempt by health.mandatory: false: knowledge-ingest-worker |

The exemption stays visible on every preview instead of being inferred from an absent field. Omitting health altogether is still a failure (JorisJonkers-dev/github-workflows#100), so an oversight remains distinguishable from a decision.

No deployment impact

diff -rq over both out/manifests and out/apply, rendered before and after the change, reports no differences. The worker still renders with no probes. health.mandatory was already in the deployment schema and previously unused.

Pins

github-workflows moves to v0.16.0 — the release where the check honours this field, and where a pin actually selects the action code that runs (until v0.15.2, an empty job_workflow_sha meant every consumer ran main regardless of its pin).

knowledge-ingest-worker is a RabbitMQ consumer. Its cluster manifest declares
no ports and no readiness or liveness probe, so there is no HTTP surface to
probe, and the SC-11 health_declared check -- which requires a health.path
from every workload -- could not be satisfied for this deployment.

health.mandatory: false records that deliberately. The check now reports pass
and names the exemption in its detail column, so the decision stays visible on
every preview rather than being inferred from an absent field. Omitting health
altogether is still a failure, which keeps an oversight distinguishable from a
decision.

The rendered output is byte-identical before and after: diff -rq over both
out/manifests and out/apply reports no differences, and the worker still
renders with no probes. This is a declaration change with no deployment
impact.

github-workflows pins move to v0.16.0, which is where the check honours the
field and where a pin selects the action code that runs.
@ExtraToast ExtraToast added the type: feature New user-facing or operator-facing capability. label Aug 20, 2026
@ExtraToast ExtraToast self-assigned this Aug 20, 2026
@ExtraToast
ExtraToast merged commit 2d4f689 into main Aug 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New user-facing or operator-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant