fix(deploy): point agent-gateway's liveness probe at the liveness group - #39
Merged
Conversation
agent-gateway declares only health.path, so the probe rendering introduced in schema 0.21 falls back to the readiness path for livenessProbe as well. The two are different actuator groups: readiness reports readinessState, liveness reports livenessState and ping. Sharing one path means a failing dependency fails liveness too, and the kubelet restarts the pod instead of removing it from endpoints - turning a transient outage into a restart loop. The endpoint is configured, not assumed: services/agent-gateway/src/main/resources/application.yml sets management.endpoint.health.probes.enabled: true, management.endpoint.health.group.liveness.include: livenessState,ping and management.endpoints.web.base-path: /api/actuator, on server.port 8090 which is the port the manifest already probes. agents-login is unchanged. It is a Fastify service exposing a single /healthz with no separate groups, so one path for both probes is correct there. Verified by rendering against schema 0.22.0 and the published context: agent-gateway readiness=/api/actuator/health/readiness, liveness=/api/actuator/health/liveness; agents-login /healthz for both.
Deploy Preview — agent-runtimeEnvironments: production Image refs
SC-11 Readiness Scorecard
Updated by deploy-check on push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 0.22.0 bump, which was deliberately left out of it:
agent-gatewaydeclares onlyhealth.path, so the probe rendering introduced in schema 0.21 falls back to the readiness path forlivenessProbetoo.Those are different actuator groups — readiness reports
readinessState, liveness reportslivenessState,ping. Sharing one path means a failing dependency fails liveness as well, so the kubelet restarts the pod instead of just removing it from endpoints. A transient outage becomes a restart loop.The endpoint is configured, not assumed
This was held back from the estate bump because
agent-gatewayis not deployed, so the path could not be confirmed against a live pod. It is confirmed from source instead —services/agent-gateway/src/main/resources/application.yml:/api/actuator/health/livenessexists and is explicitly grouped, on the same port 8090 the manifest already probes.agents-login is unchanged
It is a Fastify service exposing a single
/healthzwith no separate groups, so one path for both probes is correct. The edit is scoped to the actuator readiness path and does not touch it.Verification
Rendered against schema
0.22.0and the published context@sha256:e839b908…,exit=0, no failing gates:agent-gateway/api/actuator/health/readiness/api/actuator/health/livenessagents-login/healthz/healthz