ci(nix): release from the development shell, and stop compiling in Dockerfiles - #50
Open
Joibel wants to merge 1 commit into
Open
ci(nix): release from the development shell, and stop compiling in Dockerfiles#50Joibel wants to merge 1 commit into
Joibel wants to merge 1 commit into
Conversation
…ckerfiles The release built Argo three more times, each with its own Go toolchain: a `golang:alpine` builder stage in `Dockerfile`, a Chocolatey-installed Go on a Windows servercore stage in `Dockerfile.windows`, and `actions/setup-go` in the CLI matrix — none of which the development shell pins, and all of which had to be moved by hand when go.mod moved. Every binary is now compiled by `nix develop --command make dist/...`, and the Dockerfiles only assemble what comes out: * `Dockerfile` loses its `builder` and `argo-ui` stages. The production stages COPY from `dist/`, as the Tilt dev stages already did. The only compiler left is a small stage that builds Delve for those dev images; `/etc/mime.types`, which used to come from the builder, comes from Alpine. * `Dockerfile.windows` no longer installs Go, make, dep or git. `argoexec.exe` is cross-compiled from Linux and the Windows runner assembles the nanoserver image around it. Chocolatey stays for one thing the final image needs and nanoserver does not ship — the 7-Zip console binary — alongside servercore's netapi32.dll. * `release.yaml` builds the UI, the CLI matrix, the image binaries and the release artefacts in the shell. This also settles the Node version: the UI was built with 24 here and 22 everywhere else. * `make argoexec-image` and friends build their binary first, so they still work from a clean tree, and Tilt's CI mode compiles before it assembles. buildx keeps building and pushing the multi-arch images; only what it packages has changed. The Docker layer cache goes: with nothing compiled in the image there is nothing left to cache but a base image and a binary that differs every build, and the Go build cache — now keyed per target — does the work it did. Deferred, as planned: derivation builds (buildGoModule + vendorHash), the UI in Nix (fetchYarnDeps), and hermetic image contents. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H871PuNyYPzjmpUhXCRXGA Signed-off-by: Alan Clucas <alan@clucas.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #49
Chain of upstream PRs as of 2026-07-30
PR build(nix): one tools-only flake at the repo root #46:
nix-stack-base←tb-ufbi.1-pr1PR ci(nix): build the development shell into the Cachix cache #47:
tb-ufbi.1-pr1←tb-ufbi.2-pr2PR ci(nix): run the codegen, lint and docs gates in the development shell #48:
tb-ufbi.2-pr2←tb-ufbi.3-pr3PR ci(nix): run the build, test, UI and e2e jobs in the development shell #49:
tb-ufbi.3-pr3←tb-ufbi.4-pr4tb-ufbi.4-pr4←tb-ufbi.7-pr7Fixes #TODO
Motivation
Modifications
Verification
Documentation
AI
🤖 Generated with Claude Code
https://claude.ai/code/session_01H871PuNyYPzjmpUhXCRXGA