Fix Vector update metadata and version checks#764
Open
Shallow-dusty wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Vector’s manager/module update metadata to reference the JingMatrix/Vector repository, improves parsing of release asset version codes from current asset naming schemes, tightens the manager “update available” prompt logic, and moves native compile-time macro injection into CMake compile definitions to avoid Gradle flag quoting issues (notably on Windows).
Changes:
- Update update/install URLs (update.json, module.prop, app strings, and GitHub API endpoint) from
JingMatrix/LSPosedtoJingMatrix/Vector. - Parse release asset version codes via regex and only indicate an update when
latest_version > BuildConfig.VERSION_CODE. - Replace Gradle
cFlags/cppFlagsmacro injection with CMaketarget_compile_definitionsdriven by-DCMake arguments.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| zygisk/update.json | Points Zygisk module update metadata to Vector release/changelog URLs. |
| zygisk/src/main/cpp/CMakeLists.txt | Moves injected package/UID/manager package macros into target_compile_definitions. |
| zygisk/module/module.prop | Updates module updateJson URL to the Vector repo. |
| zygisk/build.gradle.kts | Passes injected package parameters to CMake via arguments instead of compiler flags. |
| native/CMakeLists.txt | Defines VERSION_CODE/NAME via target_compile_definitions from CMake args. |
| magisk-loader/update/zygisk.json | Updates Magisk loader metadata URLs to Vector. |
| build.gradle.kts | Passes version info to CMake via -DVECTOR_VERSION_* arguments and removes c/cpp flags injection. |
| app/src/main/res/values/strings_untranslatable.xml | Updates install/latest URLs to Vector. |
| app/src/main/java/org/lsposed/manager/util/UpdateUtil.java | Switches update check to Vector releases API; parses versionCode via regex; simplifies update-needed logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JingMatrix/Vectorinstead of the oldJingMatrix/LSPosedURLs.Vector-v2.0-3021-Release.zipare handled robustly.cFlags/cppFlagsstring injection into CMaketarget_compile_definitions, avoiding Windows quoting issues for string macros.Why
The manager could report that Vector needed an update even when the installed build was newer than the latest published release. This happened because the update check still targeted the old LSPosed release endpoint and because the stale/failed-check fallback treated old check timestamps as an update condition.
Validation
JingMatrix/Vectorrelease assets are namedVector-v2.0-3021-Debug.zipandVector-v2.0-3021-Release.zip.git diff --check origin/master..HEAD../gradlew.bat --no-daemon :app:assembleDebug :app:compileDebugJavaWithJavac :zygisk:zipDebug.v2.0 (3043)enabled=true,update=false2.0 (3043), API101./gradlew.bat --no-daemon checkwas also attempted, but it failed before project checks ran because Gradle could not download lint dependencies from Google Maven / Maven Central due to TLS handshake failures in this local network environment.