Skip to content

hotfix: changed format of searchchest#393

Merged
Jikoo merged 3 commits intoJikoo:masterfrom
tonyjamesstark:hotfix-searchchest_format
May 4, 2026
Merged

hotfix: changed format of searchchest#393
Jikoo merged 3 commits intoJikoo:masterfrom
tonyjamesstark:hotfix-searchchest_format

Conversation

@tonyjamesstark
Copy link
Copy Markdown

/searchchest format tweak

Printed output of /searchchest command now includes the CustomName and prints as list
<container type>: <custom_name if exists> - (<coords separated by commas>)

e.g.

Containers holding LIGHT_BLUE_WOOL: 
shulker_box: two -  (-991,70,775)
shulker_box:  (-986,70,774)
chest:  (-986,70,775)
chest:  (-986,70,776)
chest: one -  (-991,70,771)

Edited files:
openinv.command.SearchContainerCommand.java

Applied and tested to 1.21.11-version plugin release, though the changes should be compatible with newer versions as well.

Copy link
Copy Markdown
Owner

@Jikoo Jikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the reason you think the nameable name is important? The inventory type is important to some degree because it helps admins locate the correct container. If the inventories are already named, that suggests some level of commitment to organization, which means extra help is likely not needed.

I would also like to hear the reasoning behind replacing the comma separation with newline separation. The reason the list is comma-separated is that for some searches there is a possibility that there will be a lot of results. Since we aren't paginating, using newlines generally becomes unreadable if there are too many matches found.

Comment thread plugin/src/main/java/com/lishid/openinv/command/SearchContainerCommand.java Outdated
Comment thread plugin/src/main/java/com/lishid/openinv/command/SearchContainerCommand.java Outdated
Comment thread plugin/src/main/java/com/lishid/openinv/command/SearchContainerCommand.java Outdated
Jikoo

This comment was marked as resolved.

@tonyjamesstark
Copy link
Copy Markdown
Author

tonyjamesstark commented Apr 28, 2026

Sorry fat fingered the button.

This was a change requested by one of our players as we have found use for the command from users and not specifically admin. The intent was to make it slightly more user friendly. Also we are using fairly small radius so the length of results is never too long. That said pagination would be a great addition, though would require more doing. Meant mainly as I had implemented it on our server and thought others may find the change useful, take it as it is.

And also I would argue that comma separated output is unreadable as it is :)

and yeah, I forgot to run it through my linter my bad

Copy link
Copy Markdown
Owner

@Jikoo Jikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good overall then. Pagination probably won't be a thing until search gets split out into a separate addon, honestly - existing search isn't great and I strongly encourage people to use logging plugins instead if they need to actually locate stolen items. Sounds like your use case is more of a memory aid, which is one of the few sane ways to use the current system.

Comment thread plugin/src/main/java/com/lishid/openinv/command/SearchContainerCommand.java Outdated
@Jikoo Jikoo merged commit 8f058fb into Jikoo:master May 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants