hotfix: changed format of searchchest#393
Conversation
Jikoo
left a comment
There was a problem hiding this comment.
Could you explain the reason you think the nameable name is important? The inventory type is important to some degree because it helps admins locate the correct container. If the inventories are already named, that suggests some level of commitment to organization, which means extra help is likely not needed.
I would also like to hear the reasoning behind replacing the comma separation with newline separation. The reason the list is comma-separated is that for some searches there is a possibility that there will be a lot of results. Since we aren't paginating, using newlines generally becomes unreadable if there are too many matches found.
|
Sorry fat fingered the button. This was a change requested by one of our players as we have found use for the command from users and not specifically admin. The intent was to make it slightly more user friendly. Also we are using fairly small radius so the length of results is never too long. That said pagination would be a great addition, though would require more doing. Meant mainly as I had implemented it on our server and thought others may find the change useful, take it as it is. And also I would argue that comma separated output is unreadable as it is :) and yeah, I forgot to run it through my linter my bad |
Jikoo
left a comment
There was a problem hiding this comment.
Sounds good overall then. Pagination probably won't be a thing until search gets split out into a separate addon, honestly - existing search isn't great and I strongly encourage people to use logging plugins instead if they need to actually locate stolen items. Sounds like your use case is more of a memory aid, which is one of the few sane ways to use the current system.
/searchchestformat tweakPrinted output of
/searchchestcommand now includes the CustomName and prints as list<container type>: <custom_name if exists> - (<coords separated by commas>)
e.g.
Edited files:
openinv.command.SearchContainerCommand.java
Applied and tested to 1.21.11-version plugin release, though the changes should be compatible with newer versions as well.