Fix Stale Album Artwork and Track Data in Spotify Now Playing Card - #8429
Open
kanishka-2007-tech wants to merge 1 commit into
Open
Fix Stale Album Artwork and Track Data in Spotify Now Playing Card#8429kanishka-2007-tech wants to merge 1 commit into
kanishka-2007-tech wants to merge 1 commit into
Conversation
Contributor
|
@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses the issue of stale album artwork and track data by adjusting the caching strategy for the Spotify API. The changes ensure that the data is refreshed more frequently while still minimizing unnecessary API calls. This aligns with our previous decisions to enhance user experience through better data handling. Thank you for your contribution, and I look forward to your updates! |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
app/api/spotify/route.ts:cache: 'force-cache'(indefinite,never revalidates) with
next: { revalidate: 30 }. This still avoidsre-downloading the image on every single request, but guarantees it
can't be held onto indefinitely.
Cache-Control— tightened frompublic, max-age=30, s-maxage=30, stale-while-revalidate=30topublic, max-age=10, s-maxage=10, stale-while-revalidate=10, cutting theworst-case staleness window from ~60s down to ~20s while still protecting
the Spotify API from being hit on every card load.
The explicit
refresh/bypassCachequery params are untouched and stillforce
no-cache, no-store, must-revalidatefor callers who want a guaranteedlive fetch.
Fixes #8278
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.