Enhance Heatmap Accessibility with Keyboard Navigation and ARIA Support - #8358
Conversation
|
@nishtha-agarwal-211 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request significantly enhances the accessibility of the heatmap component by implementing keyboard navigation and ARIA support, which aligns with our previous decision to enhance customizer accessibility. The addition of comprehensive unit tests also ensures that these features are well-covered. Thank you for your contribution, and I look forward to your updates! |
3a9d24a to
8c28bd9
Compare
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Comprehensive accessibility enhancement for the heatmap components. The keyboard navigation (arrow keys, Enter/Space for toggling), ARIA labels, focus management, and the dedicated accessibility test file show thorough attention to inclusive design.
CI is failing — please check the logs and push fixes.
Labels: level:advanced (7 files, 783 lines, multi-component a11y overhaul), quality:clean, type:feature, type:accessibility, type:testing, mentor:Aamod007
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.
Description
Fixes #8303
Add full keyboard accessibility and screen reader support to contribution heatmap grid cells in
Heatmap.tsxandActivityHeatmapPro.tsx:ArrowUp,ArrowDown,ArrowLeft, andArrowRightarrow keys.aria-live="polite"announcement region that reads cell date and commit count details when focused.focus:ring-2 focus:ring-emerald-500) matching active theme color palette.Pillar
Visual Preview
ArrowUp,ArrowDown,ArrowLeft,ArrowRight) moves focus across cells seamlessly.aria-live="polite"updates with text like"5 contributions on Jan 1, 2024"on focus.Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.