Skip to content

Fix Generator: Ensure Languages View Respects dim_weekends Parameter - #8318

Open
ChetanSenta wants to merge 1 commit into
JhaSourav07:mainfrom
ChetanSenta:fix/languages-view-dim-weekends
Open

Fix Generator: Ensure Languages View Respects dim_weekends Parameter#8318
ChetanSenta wants to merge 1 commit into
JhaSourav07:mainfrom
ChetanSenta:fix/languages-view-dim-weekends

Conversation

@ChetanSenta

Copy link
Copy Markdown
Contributor

Description

Fixes #8317

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other

What this PR does

dim_weekends is documented without per-view scoping, and view=languages
is documented as a "top languages skyline" (tower-based) view — but
generateLanguagesSVG() never called renderTowers() (the only place
dim_weekends was actually checked), so the param silently had no effect
on this view. Added the same weekend-dimming check locally to
generateLanguagesSVG's tower rendering.

Changes

File Change
lib/svg/generator.ts generateLanguagesSVG now applies the same dimmed-tower class/opacity to weekend towers when dim_weekends=true
lib/svg/generator.test.ts 2 new tests confirming the class appears/doesn't appear correctly

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have made sure that I have only one commit to merge in this PR.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request addresses an important issue by ensuring that the dim_weekends parameter is respected in the generateLanguagesSVG function. This change aligns with our documentation and improves the consistency of the tower views. Additionally, it includes new tests to verify the functionality.

It's worth noting that similar decisions have been made in the past, such as aligning the STL export tower grid with real weekdays and adding unit tests for timezone normalization. These efforts highlight our commitment to maintaining accuracy and consistency across our features.

Thank you for your contribution, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title fix(generator): view=languages now respects dim_weekends, consistent with docs and other tower views Fix Generator: Ensure Languages View Respects dim_weekends Parameter Jul 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4052.50 KB 4052.50 KB 0 B
Total CSS 338.94 KB 338.94 KB 0 B

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 type:bug Something isn't working as expected type:testing Adding, updating, or fixing tests labels Jul 27, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dim_weekends parameter was being ignored in the Languages view — good catch. Fix + test. CI failing, please fix.

Labels: level:beginner (2 files, focused fix), quality:clean, type:bug, type:testing, mentor:Aamod007

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing after noting the only CI failure is Vercel authorization (not code-related). All other checks (Format · Lint · Typecheck · Test, Production Build, CodeQL) pass. Approving — the Vercel deploy auth is a repo-level config issue, not a code problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: dim_weekends param is silently ignored by view=languages — generateLanguagesSVG never calls renderTowers()

2 participants