Skip to content

feat(pr-insights): add PR Review Velocity section - #7949

Open
rastogiradhika wants to merge 2 commits into
JhaSourav07:mainfrom
rastogiradhika:feat/pr-review-velocity
Open

feat(pr-insights): add PR Review Velocity section#7949
rastogiradhika wants to merge 2 commits into
JhaSourav07:mainfrom
rastogiradhika:feat/pr-review-velocity

Conversation

@rastogiradhika

Copy link
Copy Markdown
Contributor

Description

Fixes #7924

This PR introduces a PR Review Velocity section to the PR Insights dashboard, providing users with a clearer view of how quickly pull requests are reviewed.

Changes Made

  • Added a new PR Review Velocity component.
  • Displayed review velocity metrics within the PR Insights dashboard.
  • Added unit tests for the new component.
  • Integrated the component into the existing dashboard while preserving the current UI and functionality.
  • Ensured the implementation follows the existing project architecture and coding standards.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

##Visual Preview
image

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter. (Not applicable)
  • I have starred the repository.
  • I have made sure I have only one commit to merge in this PR.
  • The implementation follows the existing UI and project standards.
  • (Recommended) I joined the CommitPulse Discord community.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@rastogiradhika is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added status:blocked This PR is blocked due to a failing CI check. and removed status:blocked This PR is blocked due to a failing CI check. labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/6247-[hash].js 36.92 KB 35.85 KB +1.07 KB (+2.97%) 🔴 Regression
static/chunks/app/(root)/dashboard/[username]/page-[hash].js 55.24 KB 54.03 KB +1.21 KB (+2.24%) 🔴 Regression
static/css/[hash].css 42.15 KB 41.95 KB +0.21 KB (+0.49%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4062.32 KB 4052.50 KB +9.82 KB (+0.24%)
Total CSS 341.08 KB 338.94 KB +2.14 KB (+0.63%)

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Hey @rastogiradhika, this pull request has been inactive for 3 days. It will be automatically closed in 2 days if no further activity occurs.

If you are still working on this, please push your latest changes or leave a comment to keep it active.

@Aamod007 Aamod007 added level:intermediate Moderate complexity tasks type:testing Adding, updating, or fixing tests mentor:Aamod007 labels Jul 15, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title indicates this PR adds a 'PR Review Velocity section', but the diff only shows changes to \EditorPanel.empty-fallback.test.tsx\ (replacing userEvent with fireEvent). Could you please check if the right commits were pushed here?

@rastogiradhika
rastogiradhika force-pushed the feat/pr-review-velocity branch from 431abff to 3e1e7ad Compare July 15, 2026 14:35
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 15, 2026
@rastogiradhika

Copy link
Copy Markdown
Contributor Author

Hi! I'm still actively working on this PR. I'm finishing the remaining changes and will push an update shortly. Thanks!

@rastogiradhika
rastogiradhika force-pushed the feat/pr-review-velocity branch from 3e1e7ad to 519bd9b Compare July 15, 2026 16:35
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jul 15, 2026
@rastogiradhika

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007, thanks for your patience! I've completed the requested changes, rebased onto the latest upstream/main, resolved the merge conflicts, and verified that all tests, lint, and type checks are passing locally. When you have time, could you please take another look at the updated PR? Thank you

@Aamod007 Aamod007 added level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:feature New features, additions, or enhancements labels Jul 17, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the PR Review Velocity section in PRInsights components provides valuable metrics for developers. However, the CI checks are failing. Please resolve the issues and rerun the CI pipeline.

@rastogiradhika
rastogiradhika force-pushed the feat/pr-review-velocity branch from 519bd9b to 5749f2b Compare July 17, 2026 07:32

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the new commits! Since we are currently ignoring the Vercel CI failures repository-wide, and you've updated the PR, everything looks good to go from my end. Approved! 🚀

@Aamod007 Aamod007 added the level:beginner Small changes Usually isolated fixes or simple UI/text updates. label Jul 23, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the PR review velocity translations! It's great to see \ r.json\ and \pt.json\ translated correctly.

However, there are a few issues that need to be fixed before we can merge:

  1. The strings in \hi.json\ (Hindi), \ja.json\ (Japanese), \ko.json\ (Korean), and \zh.json\ (Chinese) are just copied in English. Please provide the actual translations for these languages.
  2. It looks like \package-lock.json\ was accidentally modified in this branch. Please revert the changes to \package-lock.json\ so we don't introduce unexpected dependency updates.

Please push these fixes to this branch. Once that's done, we can get this merged!

Label Justification:

  • \level:beginner: Adding translations to JSON files is a straightforward task.
  • \quality:clean: Applied as default pending full review.
  • \ ype:feature: Adds i18n support for new metrics.
  • \mentor:Aamod007: Assigned as required.

@Aamod007 Aamod007 removed level:beginner Small changes Usually isolated fixes or simple UI/text updates. level:advanced Complex contributions involving architecture, optimization, or significant feature work labels Jul 27, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR Review Velocity section looks well-integrated into the PR Insights dashboard. Adding new metrics for review velocity — fast/slow review times, average response time — is a real feature addition, and from what I can see in the diff, you've connected it to the existing PRInsightData shape from @/services/github/pr-insights.

The test changes across EditorPanel.empty-fallback.test.tsx, EditorPanel.mouse-interactivity.test.tsx, and related files are mostly improvements: swapping userEvent.type() for ireEvent.change() is acceptable for simple controlled input tests (though userEvent is still preferred for full event simulation), and the �i.advanceTimersByTimeAsync(500) replacement for �i.runOnlyPendingTimersAsync() is a more explicit timer flush which should make tests more deterministic.

The gssoc:needs-rebase label tells me this branch has drifted from main — please rebase before the maintainers do a final merge review. The level:intermediate label is correct; adding a new dashboard section with data wiring, component tests, and proper integration takes real thought about the existing architecture.

@Aamod007 Aamod007 added level:advanced Complex contributions involving architecture, optimization, or significant feature work and removed level:intermediate Moderate complexity tasks labels Jul 27, 2026
@rastogiradhika
rastogiradhika force-pushed the feat/pr-review-velocity branch from 5749f2b to 0f7c0ba Compare July 27, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:needs-rebase level:advanced Complex contributions involving architecture, optimization, or significant feature work mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pr-insights): add PR Review Turnaround & Merge Velocity breakdown visualization

3 participants