feat(pr-insights): add PR Review Velocity section - #7949
Conversation
|
@rastogiradhika is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod007
left a comment
There was a problem hiding this comment.
The title indicates this PR adds a 'PR Review Velocity section', but the diff only shows changes to \EditorPanel.empty-fallback.test.tsx\ (replacing userEvent with fireEvent). Could you please check if the right commits were pushed here?
431abff to
3e1e7ad
Compare
|
Hi! I'm still actively working on this PR. I'm finishing the remaining changes and will push an update shortly. Thanks! |
3e1e7ad to
519bd9b
Compare
|
Hi @Aamod007, thanks for your patience! I've completed the requested changes, rebased onto the latest upstream/main, resolved the merge conflicts, and verified that all tests, lint, and type checks are passing locally. When you have time, could you please take another look at the updated PR? Thank you |
Aamod007
left a comment
There was a problem hiding this comment.
Adding the PR Review Velocity section in PRInsights components provides valuable metrics for developers. However, the CI checks are failing. Please resolve the issues and rerun the CI pipeline.
519bd9b to
5749f2b
Compare
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for pushing the new commits! Since we are currently ignoring the Vercel CI failures repository-wide, and you've updated the PR, everything looks good to go from my end. Approved! 🚀
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for working on the PR review velocity translations! It's great to see \r.json\ and \pt.json\ translated correctly.
However, there are a few issues that need to be fixed before we can merge:
- The strings in \hi.json\ (Hindi), \ja.json\ (Japanese), \ko.json\ (Korean), and \zh.json\ (Chinese) are just copied in English. Please provide the actual translations for these languages.
- It looks like \package-lock.json\ was accidentally modified in this branch. Please revert the changes to \package-lock.json\ so we don't introduce unexpected dependency updates.
Please push these fixes to this branch. Once that's done, we can get this merged!
Label Justification:
- \level:beginner: Adding translations to JSON files is a straightforward task.
- \quality:clean: Applied as default pending full review.
- \ ype:feature: Adds i18n support for new metrics.
- \mentor:Aamod007: Assigned as required.
Aamod007
left a comment
There was a problem hiding this comment.
The PR Review Velocity section looks well-integrated into the PR Insights dashboard. Adding new metrics for review velocity — fast/slow review times, average response time — is a real feature addition, and from what I can see in the diff, you've connected it to the existing PRInsightData shape from @/services/github/pr-insights.
The test changes across EditorPanel.empty-fallback.test.tsx, EditorPanel.mouse-interactivity.test.tsx, and related files are mostly improvements: swapping userEvent.type() for ireEvent.change() is acceptable for simple controlled input tests (though userEvent is still preferred for full event simulation), and the �i.advanceTimersByTimeAsync(500) replacement for �i.runOnlyPendingTimersAsync() is a more explicit timer flush which should make tests more deterministic.
The gssoc:needs-rebase label tells me this branch has drifted from main — please rebase before the maintainers do a final merge review. The level:intermediate label is correct; adding a new dashboard section with data wiring, component tests, and proper integration takes real thought about the existing architecture.
5749f2b to
0f7c0ba
Compare
Description
Fixes #7924
This PR introduces a PR Review Velocity section to the PR Insights dashboard, providing users with a clearer view of how quickly pull requests are reviewed.
Changes Made
Pillar
##Visual Preview

Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.README.mdif I added a new theme or URL parameter. (Not applicable)