docs: the launcher pin is documented where the engine pin is (#292) - #324
Open
mikeallisonJS wants to merge 1 commit into
Open
docs: the launcher pin is documented where the engine pin is (#292)#324mikeallisonJS wants to merge 1 commit into
mikeallisonJS wants to merge 1 commit into
Conversation
Map #292 shipped the minBootstrap floor, the lease deadline, the container ARG pin, and the upgrade/doctor halves. The docs did not move with them. - upgrading.md gains "The launcher floor": the second pin, why skew deadlocks, what boot does about it, and how to fix a violation. - The `--cli` paragraph described the pre-#296 behaviour — it said upgrade prints a rebuild instruction for containers. It rewrites the ARG line now. - `upgrade --check` reports the Dockerfile pin as the effective CLI version for a container deployment (`cli.source: "dockerfile"`). - operating.md said doctor runs six checks. It runs seven; launcher-floor was missing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map #292 shipped in #317–#320 and #323: the
minBootstrapfloor, the credential-lease deadline, the containerARG PHOEBE_AGENT_VERSIONpin, and theupgrade/doctorhalves. The docs did not move with the code, and two passages now describe behaviour that no longer exists.docs/upgrading.md
phoebe.minBootstrapdeclaration, boot refusing to start below the floor, and the fix for a container and for a host.--cliparagraph described the pre-phoebe upgrade cannot see or move a container deployment's launcher pin, so --both advances only half #296 behaviour — that upgrade prints a rebuild instruction for a container because the launcher is baked into the image. It rewrites theARG PHOEBE_AGENT_VERSIONline now and printsphoebe start --build.--checkparagraph now notes that for a container deployment the effective CLI version is the Dockerfile pin, notnpm ls -gon the host, and that--jsonmarks itcli.source: "dockerfile".docs/operating.md
launcher-floorbullet: what it compares, where it reads the launcher version from in each deployment shape, and the two "does not apply" arms (no floor declared, local-mount engine).Docs only — no changeset, matching the convention in #244.
🤖 Generated with Claude Code