Skip to content

docs: the launcher pin is documented where the engine pin is (#292) - #324

Open
mikeallisonJS wants to merge 1 commit into
mainfrom
docs/292-launcher-floor
Open

docs: the launcher pin is documented where the engine pin is (#292)#324
mikeallisonJS wants to merge 1 commit into
mainfrom
docs/292-launcher-floor

Conversation

@mikeallisonJS

Copy link
Copy Markdown
Collaborator

Map #292 shipped in #317#320 and #323: the minBootstrap floor, the credential-lease deadline, the container ARG PHOEBE_AGENT_VERSION pin, and the upgrade/doctor halves. The docs did not move with the code, and two passages now describe behaviour that no longer exists.

docs/upgrading.md

  • New The launcher floor section, between the engine-pin section and upgrading. Covers the second version pin, why the two drift, the phoebe.minBootstrap declaration, boot refusing to start below the floor, and the fix for a container and for a host.
  • The --cli paragraph described the pre-phoebe upgrade cannot see or move a container deployment's launcher pin, so --both advances only half #296 behaviour — that upgrade prints a rebuild instruction for a container because the launcher is baked into the image. It rewrites the ARG PHOEBE_AGENT_VERSION line now and prints phoebe start --build.
  • The --check paragraph now notes that for a container deployment the effective CLI version is the Dockerfile pin, not npm ls -g on the host, and that --json marks it cli.source: "dockerfile".

docs/operating.md

  • "runs six checks" → seven, with the missing launcher-floor bullet: what it compares, where it reads the launcher version from in each deployment shape, and the two "does not apply" arms (no floor declared, local-mount engine).

Docs only — no changeset, matching the convention in #244.

🤖 Generated with Claude Code

Map #292 shipped the minBootstrap floor, the lease deadline, the
container ARG pin, and the upgrade/doctor halves. The docs did not move
with them.

- upgrading.md gains "The launcher floor": the second pin, why skew
  deadlocks, what boot does about it, and how to fix a violation.
- The `--cli` paragraph described the pre-#296 behaviour — it said
  upgrade prints a rebuild instruction for containers. It rewrites the
  ARG line now.
- `upgrade --check` reports the Dockerfile pin as the effective CLI
  version for a container deployment (`cli.source: "dockerfile"`).
- operating.md said doctor runs six checks. It runs seven;
  launcher-floor was missing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 8 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0b62dfc4-ba6a-49dc-b4cf-52ede7cfd09a

📥 Commits

Reviewing files that changed from the base of the PR and between b2baac5 and 1fa6a40.

📒 Files selected for processing (2)
  • docs/operating.md
  • docs/upgrading.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted Author is trusted by repo permissions or the VOUCHED list. label Aug 24, 2026
@mikeallisonJS mikeallisonJS added the skip-changeset No release note needed: docs-, CI-, or test-only. Skips the changeset gate. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changeset No release note needed: docs-, CI-, or test-only. Skips the changeset gate. vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant