blog: pin sidebar profile avatar locally (stop hotlinking GitHub)#233
Draft
Jesssullivan wants to merge 1 commit into
Draft
blog: pin sidebar profile avatar locally (stop hotlinking GitHub)#233Jesssullivan wants to merge 1 commit into
Jesssullivan wants to merge 1 commit into
Conversation
ProfileSidebar hotlinked https://github.com/Jesssullivan.png since #20, so any change to the GitHub account picture instantly restyles prod. Vendor the current avatar (460x460 JPEG as served by GitHub) into static/images/profile-avatar.jpg and point both the compact and desktop sidebar imgs at it. Third-party request removed; future GitHub avatar changes no longer propagate silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Vendors the current GitHub profile picture (460×460 JPEG, 38KB, as served by
avatars.githubusercontent.com/u/37297218) intostatic/images/profile-avatar.jpgand points both ProfileSidebar imgs (compact 64px + desktop 250px) at it. Two-line component diff + one asset.Why
ProfileSidebar has hotlinked
https://github.com/Jesssullivan.pngsince #20 (February), so any change to the GitHub account picture instantly restyles prod — operator noticed the sidebar switch to the new yellowthroat avatar and ruled: deliberate change, pin it locally. This also removes a third-party request from every page bearing the sidebar and makes the flagship immune to future avatar drift, GitHub rate-limiting, and incidents (today's gxycch3076xk-style).Verification
svelte-check --threshold error: 0 errors (aftersvelte-kit sync+ prebuild in a fresh worktree)Notes
shadow-preview.yml, whose infra-dispatch step is currently failing (TIN-2902 lane breakage + a 401 observed during the GitHub incident) — that red would be pre-existing lane state, not this change. Flip to ready + merge whenever you're at the helm; merging deploys prod.