release: add provenance evidence bundle - #99
Merged
Conversation
Add candidate tarball hashes and published tag/package provenance checks while keeping release mutations out of the verification workflow. Co-authored-by: Hermes
JeremyDev87
commented
Jul 17, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
현재 head 전체 diff 리뷰에서 High blocker 2건을 확인했습니다. 상세 verdict와 검증 근거는 별도 top-level ddalggak review comment에 기록합니다.
Owner
Author
|
PR #99의 current head 전체 diff와 두 remediation을 재검토한 결과 차단 이슈가 없습니다. Verdict: 검증 근거 / Checks
Finding closure / Scope / Boundary
Wiki Context Manifest
CI / formal review / merge boundary
|
- trusted helper로 tag를 검증한 뒤 명시적 tag ref를 checkout - release evidence 회귀 테스트를 PR CI matrix에 연결 - workflow event 값을 환경변수로 전달해 shell interpolation을 차단 Co-authored-by: Hermes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
latest/nextdist-tags across the root package and optional native addon packages.refs/tags/...target, and pass event metadata through environment variables instead of shell interpolation.Why
Release verification must leave an inspectable candidate/package/provenance receipt and must not silently accept missing or mismatched registry evidence.
Scope / boundaries
package.jsonremains unchanged because the issue marks it inspect-only.Validation
npm run verify— PASS (9 passed, 1 environment-gated native smoke skipped)node --test test/release-evidence.test.js— PASS (6/6)cargo test --workspace— PASScargo clippy --workspace --all-targets— PASS; existing warnings onlyactionlint 1.7.12— PASS for the three changed workflowsnode --check scripts/lib/release.mjs— PASSgit diff --check— PASSRisk / follow-up
Closes #94