test: CI addon artifact smoke 연결 - #98
Merged
Merged
Conversation
CI에서 패킹한 현재 플랫폼 addon tarball을 root consumer smoke에 직접 주입해 artifact 경로를 검증한다. Co-authored-by: Hermes
Owner
Author
Hermes Independent Review — approve
HERMES_REVIEW_APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
npm pack한 현재 플랫폼 addon tarball을 root package consumer install에 사용하도록 연결했습니다.이유
기존 native smoke는 동일 바이너리를 다시 임시 패키징해 설치하므로, CI가 생산한 addon tarball이 root optional dependency 경로에서 실제로 사용되는지는 증명하지 못했습니다.
검증
KRATOS_PACKAGE_SMOKE_NATIVE_LIB=target/release/libkratos_node.dylib KRATOS_PACKAGE_SMOKE_ADDON_TARBALL=<staged tarball> node --test test/package-smoke.test.jsnpm run verifycargo test --workspacecargo clippy --workspace --all-targetsgit diff --check경계
Closes #93