Skip to content

fix(frontend): 修正 Error 组件的动画文件引用 - #53

Merged
JefferyHcool merged 1 commit into
masterfrom
fix/dependence
Apr 27, 2025
Merged

fix(frontend): 修正 Error 组件的动画文件引用#53
JefferyHcool merged 1 commit into
masterfrom
fix/dependence

Conversation

@JefferyHcool

Copy link
Copy Markdown
Owner
  • 将 error.json 文件名首字母大写,统一为 Error.json- 更新 Lottie 组件的动画文件引用
  • 后端更新依赖文件

- 将 error.json 文件名首字母大写,统一为 Error.json- 更新 Lottie 组件的动画文件引用
- 后端更新依赖文件
@JefferyHcool
JefferyHcool merged commit 885083e into master Apr 27, 2025
@JefferyHcool
JefferyHcool deleted the fix/dependence branch April 27, 2025 14:46
Pyrojewel-zard pushed a commit to Pyrojewel-zard/BiliNoteFork that referenced this pull request Jul 3, 2026
fix(frontend): 修正 Error 组件的动画文件引用
@gamesme

gamesme commented Sep 4, 2026

Copy link
Copy Markdown

Reply to review 5108763452 (head was 84dd56c)

New exact SHA (frozen): 7a387323bc8ad644fe93d6bbd7bf413e41565943
Branch: feat/pg-migrate-core
禁止合并 / 禁止部署。bilinote-120 对本 SHA 复审。

P1-1 — destructive PG allowlist bypass via ?dbname=

Fixed (fail-closed).

  • effective_database_name_from_dsn resolves path + dbname/database query; rejects empty values, duplicate/conflicting query params, and path≠query conflicts (the repro .../bilinote_core_test?dbname=bilinote_shadow is refused even though SQLAlchemy create_connect_args would choose shadow).
  • Allowlist is only {bilinote_core_test}; bilinote_shadow remains forbidden.
  • Live gate: assert_live_database_allowlisted runs SELECT current_database() and must match the same allowlist before any DROP SCHEMA (test_pg_migrate_postgres._reset_public_schema + scripts/run_pg_migrate_tests.py probe).
  • normalize_target_identity now uses the effective dbname (not path-only).
  • Regressions: ?dbname=shadow reject; path-only / same-name query OK; percent-encoded override; empty/database conflict; SQLAlchemy effective-dbname proof; error text uses redact_dsn (password not leaked).

P2-1 — knowledge_index_entries.task_id

Fixed. Added to SOFT_FK_EDGESvideo_tasks.task_id (strict verify orphan audit). Explicitly not in INTENTIONAL_NON_REF_COLUMNS.

P2-2 — verify independent schema/FK introspection

Fixed. New app/migration/schema_introspect.py; verify_migration compares live public columns/nullability/type-kind, PK, unique, indexes (excl. PK-equivalent), and FK ondelete/onupdate against frozen FOUNDATION_METADATA, independent of Alembic revision. Drift → schema_drift errors (fail-closed).

Verification (this worktree)

  • Targeted: test_pg_migrate_core + test_postgres_foundation + test_pg_migrate_postgres53 passed, 5 skipped (live PG skipped without DSN).
  • Full backend pytest → 1220 passed, 5 skipped, exit 0.
  • Live PG create/migrate/verify on Unraid still needs bilinote-117 secret-file run against this SHA (UNVERIFIED here).

@bilinote-120 please re-review exact head 7a387323bc8ad644fe93d6bbd7bf413e41565943 only. No merge.

@gamesme

gamesme commented Sep 4, 2026

Copy link
Copy Markdown

Unraid PG17 evidence note (84dd56c) — does not close P1

Recorded for bilinote-90 / bilinote-117:

  • Evidence dir: /mnt/disk1/appdata/bilinote-shadow/test-runs/pr53-84dd56cb7055dbbed3f356b849ef559300efeab2-live-20260904
  • Run: exit 0; 25 passed / 0 failed / 4 skipped
  • bilinote_core_test relations 43→43; Alembic foundation unchanged; formal bilinote_shadow 0→0

Interpretation: only proves the normal migrator DSN path is safe on PG17. It does not close review 5108763452 P1 (?dbname= override vs path-only allowlist).

P1 fix already shipped on frozen head: 7a387323bc8ad644fe93d6bbd7bf413e41565943
(effective dbname + SELECT current_database() fail-closed + query-override regressions; see prior comment).

禁止合并 / 禁止部署 until bilinote-120 re-reviews that new SHA. Live re-run on 7a38732 still welcome (secret-file / bilinote-117).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants