Make UUID changes immutable & add network splitting#36
Merged
Conversation
Starting the core overhaul branch, I've chosen to first refactor the network graph, after noticing the lifecycle problem with nodes being created with temporary UUIDs, loaded later, and then being renamed. Network node IDs are now assigned before construction and no longer mutate after the node enters a network. Component items now receive their persisted node ID before creating their node. Block entities use a small lazy holder (LazyNetworkNode) to bridge Minecraft's loading bullshit with this new approach. These changes also remove Network.rename() and the node load hook redundant, since persistence is handled outside the graph. Removed them accordingly. OpenOS launches fine.
…, removed the recently added TODOs.
Closed
3 tasks
Collaborator
Author
|
Admittedly, I didn't think much about UUID collisions, but I'm going to roll with it for this pull for now. I'll fix it in a different PR. |
Collaborator
Author
|
Itz lying!!! I've yet to outline the architecture, as well as move the computer out. |
Replace separate machine/code registries with a unified MachineBuilder, move Lua machine setup behind LuaMachineArchitecture, and simplify EEPROM default code loading through EepromItem. Last change on this branch, the next one will attempt to make a split between the Core API & the Core itself, making the boundaries clear-er as well as, hopefully, reducing the OOP-for-the-sake-of-OOP bloat
JasonTheKitten
approved these changes
Jun 4, 2026
mjarduk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.