Skip to content

History - #2

Open
JanikOskar wants to merge 10 commits into
masterfrom
history
Open

History#2
JanikOskar wants to merge 10 commits into
masterfrom
history

Conversation

@JanikOskar

Copy link
Copy Markdown
Owner

Comment thread calc/src/App.css Outdated
Comment thread calc/src/App.css Outdated
@pumanitro

Copy link
Copy Markdown
Collaborator

It would be awesome to remove those directories nesting:
image
And include all files to the root directory.

@pumanitro

Copy link
Copy Markdown
Collaborator

Those margins selected with red square are not proper one:
image

@pumanitro

Copy link
Copy Markdown
Collaborator

Please add gray backgroung on hover for digits and remove this blue background on click:
image

@pumanitro

Copy link
Copy Markdown
Collaborator

Please add functionality when I click on a behavior sign like +/-* to show it automatically above to have information what I have clicked.

@pumanitro

Copy link
Copy Markdown
Collaborator

There is no space between number and operation:
image

@pumanitro

Copy link
Copy Markdown
Collaborator
  1. Make any operation like 8/6
  2. Click = sign
  3. Starts new operation e.g. click on any digit
  4. observe some 0/0 sings added to last operation:
    image
    Please fix it.

@pumanitro

Copy link
Copy Markdown
Collaborator

Style those green elements only with one class and those in red with another one:
image
We don't need separate class to style the same behavior.

@pumanitro

Copy link
Copy Markdown
Collaborator

I found in code negative margin

#dziee
margin-top: -310px;

Please double-check if all my old comments are fixed.

@JanikOskar

Copy link
Copy Markdown
Owner Author

@pumanitro zobacz teraz, z tym zeby od razu mi sie pokazywalo nie wiem jak, ale zrobilem =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants