curated matches#84
Merged
Merged
Conversation
This table contains some hard coded results and shows what it could look like when populated with data. Next steps are to add the data lookup code and tweak the layout of the table.
This adds a new section to the help page that will describe the curated results section of the search.
Adds the endpoint that returns the curated matches from our DynamoDB.
Now that the API has been created, the result processing needed to be fixed, because the response from the API differed from the one that was being used during testing.
This makes it possible to hide the curated matches and view the computed matches, if the curated matches are not what you are looking for.
To prevent them from being spread too far across wide screens.
The type and instance text of a match now links back to a search using that text.
This plus the change of 'Results' to 'Query Results' is supposed to indicate that the user is querying the meta data and does not get a "search" result until they click on the Color Depth Search Results button or the PatchPerPixMatch Results button.
Removes the pagination controls if there two or fewer results as the default page size has been changed to two items per page.
This needed to be done, so that people could search for cell types with short names, like "EL".
In order to address some parent type/subtype uncertainty during the curation process, we are linking to the wildcard search for a cell_type so that all results are returned when clicking on it.
This indicates if a wildcard should be added to the result when clicking on it and adding it to the search bar.
When performing a wildcard search, there are times when the Additional matches in different datasets" message would appear when it was not supposed to. This is because the search could return multiple hits for the wildcard, eg LHPD2c7* would return a hit for LHPD2c7 and LHPD2c7_R, these contain 4 and 2 bodyIds respectively, with two of the bodyIds overlapping. The code filtered out the duplicates at a later stage, but did not do so, before the check that displays the "Additional matches ...." message. This adds a check to remove all bodyIds that have been seen before and prevents the message from being shown at the wrong time.
Moves the pagination controls to the bottom of the results table, to make it more obvious that there are more than 2 results.
The idea is to draw more attention to the result count, so people don't think there are only 2 results.
Object.entries() was incorrectly used on a string, causing metadata fetches to fail and returning no search results. Also switches faBookmark import to free-solid-svg-icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@krokicki