feat(project): resolve TargetFramework from subdirs for .sln/.slnx#7454
Open
MO2k4 wants to merge 6 commits intoJanDeDobbeleer:mainfrom
Open
feat(project): resolve TargetFramework from subdirs for .sln/.slnx#7454MO2k4 wants to merge 6 commits intoJanDeDobbeleer:mainfrom
MO2k4 wants to merge 6 commits intoJanDeDobbeleer:mainfrom
Conversation
…epth to project segment
- Reuse root LsDir entries instead of re-listing pwd - Track relative paths in BFS queue, eliminating filepath.Rel - Remove redundant comment
MO2k4
force-pushed
the
feat/project-sln-tfm-resolution
branch
from
66ce33a to
2e5708b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7399
Summary
projectsegment matches a.sln/.slnxfile that has noTargetFramework, scan subdirectories for.csproj/.fsproj/.vbprojfiles and extract the TFM from the first matchresolve_target_from_solution(defaulttrue) to opt out, andsolution_search_depth(default2) to control BFS depth.slnffiles are intentionally excluded from scanningTest plan
.slnxtrigger,.slnfexclusion, no project files foundTestDotnetProjecttests pass (no regressions)go vetclean