chore: drop URL output requirement from PR status summary#328
Closed
JacobPEvans wants to merge 1 commit into
Closed
chore: drop URL output requirement from PR status summary#328JacobPEvans wants to merge 1 commit into
JacobPEvans wants to merge 1 commit into
Conversation
GitHub PR/issue refs like #42 are already clickable in Ghostty and Claude Code, so the full https://github.com/... URL was redundant output. Strip the URL from the Canonical PR Status Summary format, the matching fetch instruction in /ship, and the now-unused `url` field from the GraphQL query. Assisted-by: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Canonical PR Status Summary pattern to use PR numbers instead of full URLs across documentation and examples. This includes removing unnecessary URL-fetching commands and GraphQL fields from the gh-cli-patterns and ship skill documentation. A review comment suggests clarifying the separator convention for status tags to resolve inconsistencies between the instructions and the provided examples.
Owner
Author
|
Changed my mind, this is not a good change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#42style refs are already clickable in Ghostty / Claude Code, so the fullhttps://github.com/<OWNER>/<REPO>/pull/NURL in every PR status summary was redundant noise.gh-cli-patterns; PRs are now identified by#N.gh pr view ... --json urlblock in/ship.urlfield from the open-PR GraphQL query.Pure removal — no new instructions, no format additions beyond the
#Nref the user explicitly named as the replacement.Test plan
/shipand/finalize-prsummaries render with#Nrefs and remain clickable in Ghosttyhttps://github.com/<OWNER>/<REPO>/pull/placeholders ingithub-workflows/skills/