Skip to content

[update] 1.21.6/7/8#304

Open
AlwaysHAK wants to merge 6 commits into
JackFred2:1.21.4from
AlwaysHAK:1.21.6
Open

[update] 1.21.6/7/8#304
AlwaysHAK wants to merge 6 commits into
JackFred2:1.21.4from
AlwaysHAK:1.21.6

Conversation

@AlwaysHAK

Copy link
Copy Markdown

Update to 1.21.6,

I have not extensively tested this.

@sgpl1

sgpl1 commented Jun 28, 2025

Copy link
Copy Markdown

crash when press [ ` ]
crash-2025-06-28_17.29.00-client.txt

@AlwaysHAK

Copy link
Copy Markdown
Author

It looks like you're still using the 1.21.2 version of Where Is It. Try again with the 1.21.6 version of Where Is It, I also updated that one!

1.21.6 update of Where Is It by me

@sgpl1

sgpl1 commented Jun 28, 2025

Copy link
Copy Markdown

Solved, Thx

@AlwaysHAK AlwaysHAK changed the title [update] 1.21.6 [update] 1.21.6/7 Jun 30, 2025
@z4j4l

z4j4l commented Jul 4, 2025

Copy link
Copy Markdown

is this supposed to work with servers ? im getting crashed everytime

@AlwaysHAK

Copy link
Copy Markdown
Author

Do you have the 1.21.6/7 port of Where Is It installed? See the link to that in a comment above. If you do have that installed please post the log here so I can figure out what the problem is.

@AffableMan22

Copy link
Copy Markdown

Jack really needs to update his mod, it crashes when Litematica is searching for a material list

@Mats1300

Mats1300 commented Jul 9, 2025

Copy link
Copy Markdown

can you take a look at this, ModIcon and see if you can update it to the newest Malilib. If i understand my crash code it involves renderAt method i think?

@FractalGeodes

Copy link
Copy Markdown

We also crashed on pressing grave, but fixed by installing ArchitecturyAPI. I think that's a dependency that isn't properly listed in the fabric.mod.json? But I haven't checked so it could be something else

@Mats1300

Copy link
Copy Markdown

renderAt
@AlwaysHAK After some more research it should be in that Link i provided if you don't mind looking?

@Mats1300

Copy link
Copy Markdown

Ah, yes this need updating as well please! It was pointed out by Fractal fabric.mod.json

@AlwaysHAK

Copy link
Copy Markdown
Author

Excuse me for the delay! I'm currently on holiday, I'll be back next week to see what I can do.

@ponuing

ponuing commented Jul 25, 2025

Copy link
Copy Markdown

hi, I use litematica together with these mods, when I try to open the list of resources in litematica, my game crashes due to a conflict between the chest tracker and litematica with the error
Description: Rendering screen

java.lang.AbstractMethodError: Receiver class red.jackf.chesttracker.impl.compat.mods.litematica.ModIcon does not define or inherit an implementation of the resolved method 'abstract void renderAt(net.minecraft.class_332, int, int, float, boolean, boolean)' of interface fi.dy.masa.malilib.gui.interfaces.IGuiIcon.
at knot//fi.dy.masa.malilib.gui.widgets.WidgetInfoIcon.render(WidgetInfoIcon.java:24)
at knot//fi.dy.masa.malilib.gui.GuiBase.drawWidgets(GuiBase.java:653)
at knot//fi.dy.masa.malilib.gui.GuiBase.method_25394(GuiBase.java:201)
at knot//net.minecraft.class_437.method_47413(class_437.java:113)
at knot//net.minecraft.class_757.mixinextras$bridge$method_47413$127(class_757.java)
at knot//net.minecraft.class_757.wrapOperation$bmb000$fabric-screen-api-v1$onRenderScreen(class_757.java:1423)
at knot//net.minecraft.class_757.method_3192(class_757.java:549)
at knot//net.minecraft.class_310.method_1523(class_310.java:1361)
at knot//net.minecraft.class_310.method_1514(class_310.java:947)
at knot//net.minecraft.client.main.Main.main(Main.java:265)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at com.modrinth.theseus.MinecraftLaunch.relaunch(MinecraftLaunch.java:87)
at com.modrinth.theseus.MinecraftLaunch.main(MinecraftLaunch.java:18)

@ponuing

ponuing commented Jul 25, 2025

Copy link
Copy Markdown

@AlwaysHAK @Mats1300 I fixed a bug where the game crashed when trying to open the resource list menu in litematica
Pull request
Mod build

@Leclowndu93150

Copy link
Copy Markdown

i'm so damn stupid i also made a port just now

@AffableMan22

Copy link
Copy Markdown

Really? What's the difference of your port?

@Leclowndu93150

Copy link
Copy Markdown

it's about the same

@Mats1300

Copy link
Copy Markdown

The fabric.mod.json needs to be updated then this is good to go in my eyes! Thank you @ponuing for the fix :D

@AffableMan22

Copy link
Copy Markdown

i feel like someone needs to take over the mod, the owner has been inactive for months and the mod is essential to other mods like litematica

@Leclowndu93150

Copy link
Copy Markdown

6 months isn't inactive, it's all because of the Fabric players anyways. they always want the version chasing

@AffableMan22

Copy link
Copy Markdown

I guess, I just wish each time we have to update to latest version, the mods didn't have to break each time

@rinkeChillow

Copy link
Copy Markdown

dose this work with 21.7 ???

@SergenteDonato02

Copy link
Copy Markdown

@AlwaysHAK change the title in 1.21.8 too

@SergenteDonato02

Copy link
Copy Markdown

@ponuing

ponuing commented Jul 28, 2025

Copy link
Copy Markdown

yes but it has some issue with litematica resource list

https://github.com/ponuing/ChestTracker/releases/tag/beta use this version of the mod, i fixed the crash in Litematica

@SergenteDonato02 SergenteDonato02 mentioned this pull request Jul 28, 2025
@Futuraura

Copy link
Copy Markdown

@ponuing

ponuing commented Aug 2, 2025

Copy link
Copy Markdown

@Futuraura

Copy link
Copy Markdown

Funny thing cause now it does this

https://bytebin.lucko.me/YpOg9Ad8dx

@ponuing

ponuing commented Aug 2, 2025

Copy link
Copy Markdown

Funny thing cause now it does this

https://bytebin.lucko.me/YpOg9Ad8dx

listen what do you need to do to reproduce this crash, just go into the game or what to open/set up, also have you tried turning off the chest tracker?

@Futuraura

Copy link
Copy Markdown

Funny thing cause now it does this

https://bytebin.lucko.me/YpOg9Ad8dx

listen what do you need to do to reproduce this crash, just go into the game or what to open/set up, also have you tried turning off the chest tracker?

I've opened my inventory and without chest tracker its just fine, but with chest tracker it crashes

@ponuing

ponuing commented Aug 2, 2025

Copy link
Copy Markdown

I've opened my inventory and without chest tracker its just fine, but with chest tracker it crashes

I tried to build your mods, most likely the chest tracker conflicts with
Controlify (Controller support), try to disable this mod

@SergenteDonato02 SergenteDonato02 mentioned this pull request Aug 2, 2025
@Futuraura

Copy link
Copy Markdown

Funny thing, cause it's still the same crash

@Totally-Not-Malware

Copy link
Copy Markdown

I have it working in 1.21.8 with no crashes

@sgpl1

sgpl1 commented Aug 13, 2025

Copy link
Copy Markdown

yes but it has some issue with litematica resource list是的,但它对 Litematica 资源列表有一些问题

https://github.com/ponuing/ChestTracker/releases/tag/beta use this version of the mod, i fixed the crash in Litematicahttps://github.com/ponuing/ChestTracker/releases/tag/beta 使用此版本的模组,我修复了 Litematica 中的崩溃

Can you fix its low FPS?

@oolivero45

Copy link
Copy Markdown

@AlwaysHAK I've noticed an issue with how your updated version interacts with Jade - it appears to be trying to reference a non-existent lang key, so it displays tooltips like this (note the untranslated "jade.items" and "jade.and_more" keys:
image
image

I've done a bit of digging and it appears to be due to this line added to part of the Jade compat handlers: AlwaysHAK@6399028#diff-8d03ef2684e3077b774f00277b98e05544cbfdd82c6093bc985580fe6c7fb243R44 - the key is referenced here, but is not defined anywhere in either ChestTracker or Jade's lang files.

I'm not massively familiar with Fabric development, so I may be wrong, but I think it should be a fairly easy fix - should be able to just add that translation key to the lang files.

@oolivero45

Copy link
Copy Markdown

I've managed to fix it - it looks like you were having some trouble getting the old tooltip implementation to work due to some breaking changes in how Jade handles UI elements - I've reverted to the old tooltip implementation and updated it to be compatible with Jade's new UI system.

Will PR my changes into your repo shortly :)

@SaviorFCB

SaviorFCB commented Sep 2, 2025

Copy link
Copy Markdown

I have it working in 1.21.8 with no crashes

@Totally-Not-Malware which one did you download? i downloaded the ones @SergenteDonato02 linked, but when i tried opening my inventory my game fully crashes

@AlwaysHAK AlwaysHAK changed the title [update] 1.21.6/7 [update] 1.21.6/7/8 Sep 4, 2025
@AlwaysHAK

Copy link
Copy Markdown
Author

Thanks ponuing & oolivero45 for the fixes! I've merged them and uploaded a new .jar file. This version is still compatible with 1.21.6-8

@darkralts

Copy link
Copy Markdown

hellp @AlwaysHAK is there a place i can download the .jar that works on 1.21.8?

@ponuing

ponuing commented Sep 9, 2025

Copy link
Copy Markdown

hellp @AlwaysHAK is there a place i can download the .jar that works on 1.21.8?

yes, you also need to install whereisit and Architecture API, YetAnotherConfigLib (YACL)

@ShayBox

ShayBox commented Sep 29, 2025

Copy link
Copy Markdown

I get this crash on 1.21.8 when opening my inventory

java.lang.AbstractMethodError: Receiver class net.minecraft.client.gui.screens.inventory.InventoryScreen does not define or inherit an implementation of the resolved method 'abstract net.minecraft.client.gui.screens.recipebook.RecipeBookComponent getRecipeBookComponent()' of interface red.jackf.chesttracker.mixins.AbstractRecipeBookScreenAccessor.
	at knot//red.jackf.chesttracker.impl.gui.invbutton.position.PositionUtils.getVisibleRecipe(PositionUtils.java:24)
	at knot//red.jackf.chesttracker.impl.gui.invbutton.position.PositionUtils.getRecipeComponentWidth(PositionUtils.java:39)
	at knot//red.jackf.chesttracker.impl.gui.invbutton.position.ButtonPosition.getX(ButtonPosition.java:22)
	at knot//red.jackf.chesttracker.impl.gui.invbutton.ui.InventoryButton.<init>(InventoryButton.java:64)
	at knot//red.jackf.chesttracker.impl.gui.invbutton.InventoryButtonFeature.onScreenOpen(InventoryButtonFeature.java:32)
	at knot//red.jackf.chesttracker.impl.ChestTracker.lambda$onInitializeClient$9(ChestTracker.java:135)
	at knot//net.fabricmc.fabric.api.client.screen.v1.ScreenEvents.lambda$static$2(ScreenEvents.java:101)
	at knot//net.minecraft.client.gui.screens.Screen.afterInit(Screen.java:14369)

If I disable the inventory buttons it doesn't crash, but I can't access it.
It also seems to hide the hotbar selection outline, I can't tell what slot I'm selecting.

@evenlynrose

Copy link
Copy Markdown

will you make this for 1.21.10

@FractalGeodes

FractalGeodes commented Oct 11, 2025

Copy link
Copy Markdown

1.21.10 shouldn't have many breaking changes, so porting should be as easy as making sure it's included in the supported versions field. I could be wrong though, apparently Iris got hit with some unmentioned breaking changes internally.

Edit: Assuming this mod was ported to 1.21.9 already, which is upon further inspection it seems it was not. Huh. That might be a bit more complicated, I think.

@ponuing

ponuing commented Oct 17, 2025

Copy link
Copy Markdown

@evenlynrose #317

@AffableMan22

Copy link
Copy Markdown

1.21.11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.