fix: explicit status classification in analyticsRepo - #26
Merged
Conversation
… card modal - MeetingView: always build the card description from all concluded agent messages (writer, researcher, coder, senior-coder, tester) rather than using only the tester output and falling back to everyone else - TaskDetailModal: fetch project tags on open and replace the freetext input+Add button with a <select> dropdown; only unassigned project tags are shown; selected tag is appended and removed from the dropdown; existing tag pills now use the project tag's hex color when available Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace implicit `else` branches with `else if (r.status === 'failed')` in both the summary counter loop and the weekly bucket loop, so unknown/future statuses are silently ignored rather than counted as failures. Add a new `status classification` describe block (4 tests) to analytics-repo.test.ts covering done/failed parametrized cases, double-count guards, and weekly bucket accuracy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elsebranches indbGetProjectAnalytics()with explicitelse if (r.status === 'failed')checks in both the summary aggregation loop and the weekly bucket loopChanges
lib/db/repositories/analyticsRepo.ts— two one-line fixes (summary loop + weekly bucket loop)__tests__/unit/analytics-repo.test.ts— newstatus classificationdescribe block with 4 parametrized tests coveringdone/failedclassification and double-counting guardsTest plan
npm run test:run— all 137 tests passit.eachcovers bothdoneandfailedstatus values explicitlydone/failedcounts🤖 Generated with Claude Code