A synthesised base resolves under its bare name, and Heist Gear's own lines are not modifiers - #45
Merged
Conversation
… lines are not modifiers
ADDED: two captures pinned against the bundle version each Discord report was filed against,
and the regression cases that check them
CHANGED: the base line's "Synthesised " prefix is stripped before base lookup, the same as
"Superior " already is — the bundle only ever knows a synthesised weapon or armour base under
its bare name
CHANGED: "Heist member" is a usage-note needle, so the two boilerplate lines every Heist Gear
item prints ("Any Heist member can equip this item.", "Can only be equipped to Heist members.")
are no longer read as unmatched modifiers
CHANGED: the test bundle slice gained Void Sceptre, Nebulis, Precise Arrowhead, Sceptres and
Heist Gear plus the stats both captures need, regenerated from the installed bundle matching
the reports (20260813.55 predates the checkout's own out/, which has since drifted on an
unrelated pair of logbook stats)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… is a lexicon list now
ADDED: an em-dash "Unscalable Value" suffix, and its Wine plain-hyphen fallback, to the
lexicon's new UnscalableSuffixes list, so a Heist Contract's boolean affixes ("Monsters are
Hexproof — Unscalable Value") strip cleanly before matching instead of coming back
unrecognised.
CHANGED: the numeric "(unscalable value)" parenthetical out of a bare constant and into that
same lexicon list, so every spelling of "this roll is fixed" lives in one place that can grow
without adding another constant.
ADDED: a real capture (a Smuggler's Den contract) and regression tests at the stat-matcher,
price-check and map-check layers.
Reported by the maintainer, caught testing map check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Review notes
ADDED:
UnscalableSuffixes, naming every spelling of "this roll is fixed" the game appends to a modifier: the numeric "(unscalable value)" parenthetical, the em-dash "Unscalable Value" a modifier with no roll at all gets instead, and the plain-hyphen form Wine's clipboard fallback can turn the em dash intoCHANGED:
out/, which has since drifted on an unrelated pair of logbook stats — left untouched)7(7-6)% reduced Hiring Feeon the Heist Gear capture, called out as a data-bundle gap in an earlier revision of this PR, is now fixed on the data side (PathOfPriceCheck-Datamain, no app change needed) and will resolve once that bundle ships.Test plan
ctest --test-dir build— all 24 targets pass, including the new regression cases