The slider's track reaches past the tier, and the ticks carry the claim - #30
Merged
Conversation
ADDED: `ui::widen_track` in `ppc_core` — the one rule every slider track is built with: half again either side of the numbers it is drawn around, at least one step at the row's own precision, rounded outwards. ADDED: `tests/track_test.cpp`, which is why the arithmetic sits in `ppc_core` rather than beside the ImGui widget. CHANGED: a published range is what the track is built around rather than where it ends, and the two ticks are what mark it. - The tier in hand is the only tier anything we have can name, so a track stopping there made the two most useful drags — a bit better than this, a bit worse — impossible without typing. The width is a convenience; the ticks are the claim, and they stay on `roll_min`/`roll_max` wherever the ends get to. CHANGED: `RangeTrack` carries `tick_lo`/`tick_hi` in place of a `published` flag, so the ticks are there from the first frame instead of appearing once the track has been grown. CHANGED: a tier that rolls a single number keeps its ticks; it used to fall through to the derived branch and lose them. CHANGED: the reach's floor is one step at the row's `dp` rather than a flat 1, which was ten steps on an attack speed. CHANGED: a pegged knob grows the track by a quarter of the span it started with rather than a fifth, measured against the widened track the user can actually see. CHANGED: `docs/roadmap.md` records what a per-tier affix table would really cost. - The `Mods` table the data build already extracts carries the ladders — grouping its 4,369 item-domain prefix and suffix rows by stat-key set gives `local_physical_damage_+%` as eight tiers, 40–49 through 170–179. What is missing is the spawn weights that decide which ladders can appear on the base in hand, without which the union overstates the range. REMOVED: `kDerivedSpread` and `kDerivedFloor`, folded into the single constant. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
CHANGED: The slider in a filter's range editor now reaches past what your copy of the modifier
rolled, instead of stopping at it. The range the game printed is marked by two ticks on the track,
so it is still clear which numbers are the item's and which are yours, and dragging a little better
or a little worse than the roll no longer means typing.
CHANGED: A row whose modifier rolls a single number gets a real track to drag on, and keeps the
ticks that say so.
CHANGED: A knob released hard against an end grows the track by a quarter of its length rather than
a fifth, so it takes fewer pulls to get somewhere.
Review notes
ADDED:
ui::widen_trackinppc_core— the one rule every slider track is built with: half againeither side of the numbers it is drawn around, at least one step at the row's own precision,
rounded outwards.
ADDED:
tests/track_test.cpp, which is why the arithmetic sits inppc_corerather than beside theImGui widget.
CHANGED: a published range is what the track is built around rather than where it ends, and the two
ticks are what mark it.
two most useful drags — a bit better than this, a bit worse — impossible without typing. The width
is a convenience; the ticks are the claim, and they stay on
roll_min/roll_maxwherever the endsget to.
CHANGED:
RangeTrackcarriestick_lo/tick_hiin place of apublishedflag, so the ticks arethere from the first frame instead of appearing once the track has been grown.
CHANGED: a tier that rolls a single number keeps its ticks; it used to fall through to the derived
branch and lose them.
CHANGED: the reach's floor is one step at the row's
dprather than a flat 1, which was ten stepson an attack speed.
CHANGED: a pegged knob grows the track by a quarter of the span it started with rather than a
fifth, measured against the widened track the user can actually see.
CHANGED:
docs/roadmap.mdrecords what a per-tier affix table would really cost.Modstable the data build already extracts carries the ladders — grouping its 4,369item-domain prefix and suffix rows by stat-key set gives
local_physical_damage_+%as eight tiers,40–49 through 170–179. What is missing is the spawn weights that decide which ladders can appear on
the base in hand, without which the union overstates the range.
REMOVED:
kDerivedSpreadandkDerivedFloor, folded into the single constant.🤖 Generated with Claude Code