The game patch string is checked before it reaches a shell - #1
Open
JIRPOS wants to merge 1 commit into
Open
Conversation
CHANGED: The patch version read from `poe-tool-dev/latest-patch-version` must be a dotted number and nothing else, or the run stops. - It is another project's file, and from here it reached both `$GITHUB_OUTPUT` and a command line in a job that can write to this repository. A second line in it would have written a step output of its own; a metacharacter would have run in the build step. - Tested with `[[ =~ ]]` rather than `grep`, which anchors per line and passes a string whose first line is a version. CHANGED: The build step takes the patch string through the environment instead of interpolating it into the script. CHANGED: The data version is stamped once and reused for both `--data-version` and `--tag`. Two `date` calls either side of UTC midnight would have tagged a bundle with a day its own manifest disagrees with. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review notes
CHANGED: The patch version read from
poe-tool-dev/latest-patch-versionmust be a dotted number and nothing else, or the run stops.$GITHUB_OUTPUTand a command line in a job that can write to this repository. A second line in it would have written a step output of its own; a metacharacter would have run in the build step.[[ =~ ]]rather thangrep, which anchors per line and so accepts a string whose first line is a version and whose second is anything at all.CHANGED: The build step takes the patch string through the environment instead of interpolating it into the script.
CHANGED: The data version is stamped once and reused for both
--data-versionand--tag. Twodatecalls either side of UTC midnight would have tagged a bundle with a day its own manifest disagrees with.Nothing here changes the published bundle, so there are no release notes.
🤖 Generated with Claude Code