fix: mask plugin config fields with type: 'secret' in Settings UI#537
Open
dlduke-lilly wants to merge 1 commit into
Open
fix: mask plugin config fields with type: 'secret' in Settings UI#537dlduke-lilly wants to merge 1 commit into
dlduke-lilly wants to merge 1 commit into
Conversation
Both PluginsSettingsPage and CustomPluginsSettingsPage matched
{ type: 'string' } and { type: 'secret' } together and rendered
both as plain TextField elements with no masking.
Add type={config.type === 'secret' ? 'password' : 'text'} so secret
plugin config values are masked in the Settings UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both PluginsSettingsPage and CustomPluginsSettingsPage matched
{ type: 'string' } and { type: 'secret' } together and rendered
both as plain TextField elements with no masking.
Add type={config.type === 'secret' ? 'password' : 'text'} so secret
plugin config values are masked in the Settings UI.