fix: Change the replacement symbol for masked entity#188
Merged
ChenZiHong-Gavin merged 2 commits intoInternScience:mainfrom Apr 13, 2026
Merged
fix: Change the replacement symbol for masked entity#188ChenZiHong-Gavin merged 2 commits intoInternScience:mainfrom
ChenZiHong-Gavin merged 2 commits intoInternScience:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the masked_fill_in_blank_generator.py file to change the mask placeholder from "___" to "{ }". A review comment suggests removing the commented-out original line to maintain code cleanliness and follow best practices.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K2V uses “{ }” to replace the masked entity. Although "___" is an alternative, using "{ }" is more consistent with the methodology described in the original paper.