Remove deprecated dpctl.tensor submodule#2245
Conversation
dcac1f6 to
e450664
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2245/index.html |
da4c41e to
6a5046b
Compare
|
@antonwolfy @vlad-perevezentsev |
6a5046b to
7d8bbc8
Compare
… project sans tensor
7d8bbc8 to
b610ee3
Compare
| execution_model | ||
| dlpack |
There was a problem hiding this comment.
execution_model and dlpack should also be removed from the toctree
|
|
||
| ### Removed | ||
|
|
||
| * Removed previously deprecated `dpctl.tensor` submodule, with all tensor functionality migrated to [`dpnp`](https://github.com/IntelPython/dpnp) [gh-2245](https://github.com/IntelPython/dpctl/pull/2245) |
There was a problem hiding this comment.
The main README.md file mentions tensor on line 37
in C, Cython, or pybind11 to access `dpctl` objects representing SYCL
devices, queues, memory, and tensors.
https://github.com/IntelPython/dpctl/blob/feature/uncouple-tensor-from-dpctl/README.md
This should probably be removed as well
There was a problem hiding this comment.
This regex is no longer relevant (line 225)
regexp1 = re.compile(r"^_tensor_.*impl" + sfx_regexp)
| @@ -14,18 +14,11 @@ conditions of this license. | |||
| Third party components and their licenses | |||
| ----------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
| is used to implement support for data interchanging mechanism in :py:mod:`dpctl.tensor` | ||
| as required by Python Array API specification, cf. `data interchange document <array_api_data_interchange_>`_. | ||
|
|
||
| :py:mod:`dpctl` vendors `versioneer <versioneer_gh_>`_ to generate it version from git history |
There was a problem hiding this comment.
It has still dpctl.tensor references
There was a problem hiding this comment.
The same for
https://github.com/IntelPython/dpctl/blob/feature/uncouple-tensor-from-dpctl/docs/_legacy/docfiles/intro.rst
Dpctl includes a reference implementation for :array_api:array API specification <> using DPC++ and USM memory allocation in the :class:dpctl.tensor sub-module. The :class:dpctl.tensor sub-module provides an N-dimensional array Python object :class:dpctl.tensor.usm_ndarray and a growing implementation of :array_api:array API specification <> compliant operations on instances of the array class.
There was a problem hiding this comment.
This PR removes the
dpctl.tensorsubmodule, as it is migrated to dpnp asdpnp.tensorThis change makes
dpctla much smaller, lighter-weight package, with no built-in tensor capabilities. Thememorysub-module andorder_managerremain to support tensor-like extensions, butdpctlwill focus on device management and providing a Python interface to SYCL implementations