COMP: Modernize CMake and update CI to v5.4.6 with OpenSlide system packages#37
Merged
Conversation
dzenanz
reviewed
Apr 3, 2026
dzenanz
left a comment
dzenanz
left a comment
Member
There was a problem hiding this comment.
Why not have AI implement its own suggestion(s) about the remote module action?
hjmjohnson
force-pushed
the
update-ci-v5.4.6
branch
3 times, most recently
from
2a07d86 to
7dcc0b6
Compare
Re-enable build workflows using new inputs from ITKRemoteModuleBuildTestPackageAction: - apt-packages: install libopenslide-dev on Linux - brew-packages: install openslide on macOS - os-list: skip Windows (no OpenSlide package manager distribution) Python wheel builds re-enabled with default configuration. Also updates minimum Python version to 3.10+. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hjmjohnson
force-pushed
the
update-ci-v5.4.6
branch
from
7dcc0b6 to
e90ced6
Compare
Member
|
@blowekamp this remote builds against 5.4.5, but fails against a recent main: An attempt to fix it is in https://github.com/InsightSoftwareConsortium/ITKIOOpenSlide/tree/wipInclude branch. |
blowekamp
reviewed
Apr 6, 2026
The CTest dashboard build does not automatically add the module's include/ directory to the compiler search path for the src/ library target. Without this, itkOpenSlideImageIOFactory.h is not found: fatal error: itkOpenSlideImageIOFactory.h: No such file or directory Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The add-apt-packages-input feature branch was merged into v5.4.6 as commit 7beece0. Update the CXX workflow ref to use the stable branch instead of the now-stale feature branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The module export header IOOpenSlideExport.h is generated by CMake in the build directory (CMAKE_CURRENT_BINARY_DIR). The CTest dashboard build does not automatically add this to the include path, causing: fatal error: IOOpenSlideExport.h: No such file or directory Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…eels Replace the legacy add_library + itk_module_target + include_directories pattern with itk_module_add_library, which generates the export header and propagates its include directory through target interface properties. This fixes the IOOpenSlideExport.h not-found error when building test targets in the CTest/dashboard configuration. Disable the Python wheel workflow because OpenSlide is an external C library not available in the manylinux Docker containers or Windows wheel-build environments. Assisted-by: Claude Code — root-cause analysis of export header include path propagation
hjmjohnson
changed the title
Member
|
@hjmjohnson the way to upload data to IPFS does not seem to work correctly. This fails both in CI and locally: And it seems that all recently converted remotes fail their CI. Maybe you have stood up some IPFS node on your computer which is only accessible locally? Or only accessible while it is running? |
Member
|
For example, the error on https://gateway.pinata.cloud/ipfs/bafkreifmnnz2tmcbonoxmg7h4n2tpz35obowqfi5cbyvfk7niwi4cbpymq is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable C++ CI by installing OpenSlide via
apt-packages/brew-packagesinputs and modernize the CMake build to useitk_module_add_library. Disable Python wheel builds (OpenSlide unavailable in manylinux/Windows containers).Changes
@v5.4.2→@v5.4.6, passapt-packages: libopenslide-devandbrew-packages: openslide, restrict C++ OS list to Linux/macOS (no Windows OpenSlide), disable Python wheel workflow.add_library+include_directories+itk_module_targetwithitk_module_add_library, which generates the export header and propagates its include directory through target interface properties — fixingIOOpenSlideExport.h: No such file or directoryin test targets.pyproject.toml.