Skip to content

Fix path generation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baptouuuu merged 2 commits into from
Apr 9, 2026
Merged

Fix path generation #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2397a35
prevent generating paths with 2 slashes
Baptouuuu Apr 9, 2026
72d4ef0
prevent generating relative paths starting with a backslash
Baptouuuu Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions fixtures/Path.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ public static function directories(): Set
*/
private static function strings(): Set
{
return Set::strings()->filter(
static fn($value) => (bool) \preg_match('~\S+~', $value),
);
return Set::strings()
->filter(static fn($value) => (bool) \preg_match('~\S+~', $value))
->exclude(static fn($value) => \str_contains($value, '//'))
->exclude(static fn($value) => \str_starts_with($value, '\\'));
}
}
7 changes: 7 additions & 0 deletions tests/PathTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ public function testResolveAbsolutility(): BlackBox\Proof
});
}

public function testPathStartingWithBackslashIsInvalid()
{
$this->assert()->throws(
static fn() => Path::of('\\\\'),
);
}

public static function resolutions(): array
{
return [
Expand Down
Loading