build: refresh v8-runner master snapshot - #419
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR documents a Changesv8-runner master refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
tests/ci/test_unica_skills.py (1)
2131-2133: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCheck the strict-platform contract in each required document.
The test concatenates five documents before checking three independent substrings. Strict guidance can be removed from one required reference while another document keeps the test passing. Assert the complete strict-platform contract separately for
plugins/unica/references/tooling/v8project.mdandplugins/unica/skills/v8-runner/references/config-and-backends.md.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/ci/test_unica_skills.py` around lines 2131 - 2133, Update the test around the combined v8_runner_docs assertions to validate the complete strict-platform contract independently in both required documents: plugins/unica/references/tooling/v8project.md and plugins/unica/skills/v8-runner/references/config-and-backends.md. Assert tools.platform.strict, strict: true, and fail-closed for each document rather than relying on concatenated content.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/design/2026-08-10-v8-runner-master-refresh-design.md`:
- Around line 35-37: В разделе, описывающем порядок публикации, замените
формулировку «Порядок не обращается» на «Порядок не меняется» и явно
сформулируйте правило: Unica не должна ссылаться на ещё не существующие или
непроверенные байты. Сохраните утверждения о неизменности опубликованных
release/tag и использовании следующей build revision при ошибке выпуска.
In `@docs/plans/2026-08-10-v8-runner-master-refresh.md`:
- Around line 132-158: Use a single verified workflow run identity throughout
Step 2 instead of selecting the first result from gh run list. Dispatch the
workflow with immutable ref "$merge_sha" or capture the exact dispatched run ID,
verify its headSha equals merge_sha, then pass that run ID directly to gh run
watch.
- Around line 16-18: Separate package and tool version references in
docs/plans/2026-08-10-v8-runner-master-refresh.md lines 16-18 by identifying
0.5.1 as the v8-runner version and stating Unica’s package version separately,
using package metadata as authoritative. In
docs/design/2026-08-10-v8-runner-master-refresh-design.md lines 9-13, replace
Unica v0.11.0 with the current package version or explicitly label v0.11.0 as
historical context.
- Around line 180-189: Update the release verification commands in the
documented shell flow so every check fails closed: enable fail-fast behavior for
the checksum loop and validate each provenance file independently with jq,
stopping immediately on the first checksum or provenance mismatch rather than
allowing a later successful command to determine the final status.
In `@plugins/unica/skills/v8-runner/references/config-and-backends.md`:
- Line 37: Update the host-specific sentence in the skill prose to use
mcp__plugin_unica_unica__unica_runtime_execute instead of unica.runtime.execute.
Preserve canonical unica.runtime.execute references in JSON-RPC examples and
public contract statements.
---
Nitpick comments:
In `@tests/ci/test_unica_skills.py`:
- Around line 2131-2133: Update the test around the combined v8_runner_docs
assertions to validate the complete strict-platform contract independently in
both required documents: plugins/unica/references/tooling/v8project.md and
plugins/unica/skills/v8-runner/references/config-and-backends.md. Assert
tools.platform.strict, strict: true, and fail-closed for each document rather
than relying on concatenated content.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 948d4138-ad3b-4958-8520-4b774cd70bcd
📒 Files selected for processing (8)
docs/design/2026-08-10-v8-runner-master-refresh-design.mddocs/plans/2026-08-10-v8-runner-master-refresh.mddocs/provenance/reviews/2026-08-10-v8-runner-master-refresh.jsonplugins/unica/references/tooling/v8project.mdplugins/unica/skills/v8-runner/references/config-and-backends.mdplugins/unica/third-party/tools.lock.jsontests/ci/test_skill_provenance.pytests/ci/test_unica_skills.py
|
Review follow-up in |
1 participant
Результат
7ce1b062843d86644fe55741dbe0ee79f7ca767d.Проверенные assets
darwin-arm642a92802edf5a73d5fdcc42cc61b1abbbc95226cd75bdfe3c50407b13eb8da590linux-x6470690845033ab41abe4ed0a6af206f7022cd1481ae408748b7de03c56ced0b6bwin-x64191a3d7c930007377238dda0543d1e42cc1a1bd4b209736d54fd41c0ffaac32eRelease скачан повторно: все 10 ожидаемых файлов присутствуют, checksum-файлы совпадают, provenance каждого target указывает на тот же commit и Rust 1.95.0. Native macOS
--versionиbuild --helpпрошли.Рассмотренный upstream delta
В 36-коммитном диапазоне применены как часть бинарного refresh:
test --no-buildavailability без нового MCP-аргумента;v8project.yamlconfig;Отложены отдельными контрактами:
noBuildвunica.runtime.execute;Applied
mode=incremental|partialостаётся fail-closed.Проверка
python -m unittest discover -s tests/ci: 615 passed, 3 skipped;cargo fmt --all -- --check;cargo clippy --workspace --all-targets --locked -- -D warnings;cargo test --workspace --locked;Локальный общий
check-tool-contracts.pyдважды упёрся в 120-секундный timeout неизменённогоrlm-bsl-index index build. RLM lock и bytes не менялись относительноmain; v8-runner-specific subset из того же скрипта прошёл отдельно. GitHub checks остаются обязательным финальным gate.Summary by CodeRabbit
Documentation
Updates
Tests