Update doublons.php - Fix GLPIv11#2
Open
ilionel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
doublon.php
In getLastInventory(), the WHERE clause incorrectly used computers_id as the column name when querying glpi_computers, but the primary key of that table is id — computers_id is the foreign key column name specific to the OCS plugin's glpi_plugin_ocsinventoryng_ocslinks table.
profile.php
In GLPI 11's Symfony routing, $_SERVER['PHP_SELF'] always resolves to /index.php (the front controller), so using it as a form action caused the POST to be intercepted by CatchInventoryAgentRequestListener — which expects inventory agent XML — instead of being handled by the reports plugin; replacing it with $_SERVER['REQUEST_URI'] ensures the form submits to the actual requested URL.
Lionel.