[Design Doc] Abdul Moiz Muhammad: Scaffold + Technical Approach (CNIC)Add design doc scaffold with Technical Approach section - #1
Open
M-O-J-U wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Scaffolds docs/design_doc.md with all 7 required sections. Section 3 (Technical Approach) is fully written, covering OCR library choice, the preprocessing pipeline, and real findings from testing against 4 real CNIC photos. Other sections are left as placeholders for the Lead and Integration Engineer to fill in.
Which module(s) does it touch?
docs/design_doc.md only. No code changes.
How was this tested?
Technical Approach content is based on hands-on testing of a local EasyOCR + OpenCV prototype against 4 real CNIC images (2 clear, 1 blurry, 1 tilted), not written from theory. Specific measured results (blur variance thresholds, before/after field-extraction counts) are in the section itself.
Checklist:
Followed the design doc template structure
My section is filled in with real tested findings, not placeholder text
Other sections clearly marked as not yet filled in
PR description written in my own words, not copied from the template