Refactored how the server address is obtained for the blacklist check#3
Merged
Conversation
…le Voxy on blacklisted servers
Owner
|
Thanks for the PR! Much better logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of extracting it from the path generated by VoxyClientInstance#getBasePath(), the host is now captured directly from ClientPacketListener when the connection is created. This allows the blacklist check to run inside VoxyCommon#createInstance() and fully disable Voxy on blacklisted servers.
The old path-based detection has been removed. Voxy is now completely disabled before it can proceed further, preventing it from partially running in the background or continuing to write LOD data (e.g. increasing the .voxy directory size) on blacklisted servers.