Skip to content

[TASK] make it work with TYPO3 11.5 - #6

Open
lukasniestroj wants to merge 7 commits into
IchHabRecht:masterfrom
lukasniestroj:master
Open

[TASK] make it work with TYPO3 11.5 #6
lukasniestroj wants to merge 7 commits into
IchHabRecht:masterfrom
lukasniestroj:master

Conversation

@lukasniestroj

Copy link
Copy Markdown

Hi @IchHabRecht,

I have prepared most of the files to make it work with an installed TYPO3 11.5 and an old DB (7.6).

I left .travis.yml untouched since I am unfamiliar with that.
The ext_emconf.php says

"version" and "dependencies" must not be touched!

so I didn't commit my change but it is important to set typo3 => '11.5.0-11.5.99'

In my opinion it should be a new major release 2.0.0 since it's not compatible with 10.4.

@pulponair

Copy link
Copy Markdown

@lukasniestroj
Great work but:
Call to undefined method TYPO3\CMS\Core\Resource\ResourceFactory::getInstance()

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.3/Deprecation-90260-ResourceFactorygetInstancePseudo-factory.html

in TYPO3\CMS\v87\Install\Updates\ ImageCropUpdater
and TYPO3\CMS\v87\Install\Updates\RowUpdater\ImageCropUpdater

can be easly fixed by replacing getInstance with GeneralUtility::makeInstance(ResourceFactory::class)

@lukasniestroj

Copy link
Copy Markdown
Author

@pulponair thanks. Fixed!

@dkd-kaehm

Copy link
Copy Markdown

Very nice thanks for your work @IchHabRecht and @lukasniestroj
I'll test it and provide infos as well.

@dkd-kaehm

Copy link
Copy Markdown

This PR works for me, thanks.
Would be nice to merge this PR and release the new version.

@IchHabRecht

Copy link
Copy Markdown
Owner

Hi,
Thank you for this pull request. Unfortunately it drops compatibility to TYPO3 10 which I want to support as well. If I have some time I can do some investigation.

Comment thread README.md
@dkd-kaehm

Copy link
Copy Markdown

Unfortunately it drops compatibility to TYPO3 10 which I want to support as well.

@IchHabRecht
But what about the unnecessary wizards for TYPO3 11, which will be then available for TYPO3 10
IMHO the version constraints are just fine. For TYPO3 10 the previous version must be used.

@IchHabRecht

IchHabRecht commented Jun 7, 2022

Copy link
Copy Markdown
Owner

@dkd-kaehm This is what needs to be investigated. I don't want to support multiple version of an extension if there is a way to unify those.

dkd-kaehm added a commit to dkd-kaehm/core_upgrader that referenced this pull request Jul 14, 2022
Due of BC 93029 in TYPO3 v. 11.0, which removes "deleted" column in "sys_refindex" table. The core_upgrader command can not be executed more than once.

See: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.0/Breaking-93029-DroppedDeletedFieldFromSys_refindex.html

Fixes: IchHabRecht#7
Depends: IchHabRecht#6
@joey-bolts

Copy link
Copy Markdown

I've just used this pull-request to update from V8.7 to V11. Thanks for this.
The only issue i've had is that some V8.7 wizards did not work since the installation was build in V8.7
Removing V8.7 from Web/typo3conf/ext/core_upgrader/Configuration/Upgrades.php did the job.

Thanks for this, this will save me quite some time.

@linawolf

linawolf commented Feb 9, 2023

Copy link
Copy Markdown

I did an upgrade from 8.7 to 11.5 (PHP 7.4) with this fork and it worked fine

@jokumer

jokumer commented Feb 9, 2023

Copy link
Copy Markdown

We decided within an upgrade from 8.7 to 11.5 to use a PHP 8.1 compatible version of core_upgrader. We run all upgrade wizards while all TYPO3 v11.5 compatible extensions are installed. Some of this extensions offers required upgrade wizards.
We decided so, cause new extensions are not required to be also PHP 7.4 compatible for upgrade prozess, when target PHP version is 8.1

@fnagel

fnagel commented Feb 9, 2023

Copy link
Copy Markdown

@jokumer Is there a PHP 8.1 compatible version of EXT:core_upgrader?

@jokumer

jokumer commented Feb 9, 2023

Copy link
Copy Markdown

@fnagel See forks or our last commit 3pc-Berlin@62125d2

@dkd-kaehm

Copy link
Copy Markdown

@lukasniestroj
please see in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants