Skip to content

Forward dual/isdual through NamedUnitRange #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
Jul 24, 2026
+13 −3
Merged

Forward dual/isdual through NamedUnitRange #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ITensorBase"
uuid = "4795dd04-0d67-49bb-8f44-b89c448a1dc7"
version = "0.13.4"
version = "0.13.5"
authors = ["ITensor developers <support@itensor.org> and contributors"]

[workspace]
Expand Down Expand Up @@ -48,7 +48,7 @@ Mooncake = "0.4.202, 0.5"
OMEinsumContractionOrders = "1.3"
Random = "1.10"
SimpleTraits = "0.9.4"
TensorAlgebra = "0.17.5"
TensorAlgebra = "0.17.8"
TensorKit = "0.17"
TermInterface = "2"
TupleTools = "1.6"
Expand Down
6 changes: 5 additions & 1 deletion src/namedunitrange.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using TensorAlgebra: TensorAlgebra, to_range, trivialrange, ungrade
using TensorAlgebra: TensorAlgebra, dual, isdual, to_range, trivialrange, ungrade

"""
NamedUnitRange{Name}
Expand Down Expand Up @@ -115,6 +115,10 @@ Base.hash(r::NamedUnitRange, h::UInt) = hash_named(:NamedArray, ungrade(r), h)
# otherwise short-circuit before the inner range is touched.
Base.conj(r::NamedUnitRange) = named(conj(unnamed(r)), name(r))

# Forward `dual`/`isdual` to the underlying range so an index answers its duality directly.
TensorAlgebra.dual(r::NamedUnitRange) = named(dual(unnamed(r)), name(r))
TensorAlgebra.isdual(r::NamedUnitRange) = isdual(unnamed(r))

# Unit range functionality.
Base.first(r::NamedUnitRange) = named(first(unnamed(r)), name(r))
Base.last(r::NamedUnitRange) = named(last(unnamed(r)), name(r))
Expand Down
6 changes: 6 additions & 0 deletions test/test_tensorkitext.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ using Test: @test, @test_throws, @testset
@test unnamed(conj(i)) == dual(Vi)
@test name(conj(i)) == name(i)

# `isdual`/`dual` forward to the underlying space.
@test TensorAlgebra.isdual(i) == false
@test TensorAlgebra.isdual(conj(i)) == true
@test unnamed(TensorAlgebra.dual(i)) == dual(Vi)
@test name(TensorAlgebra.dual(i)) == name(i)

# Equality is dual-insensitive: an index equals its dual (same name, same ungraded
# extent), hashes match, and a fresh index of the same space is a distinct leg. This is
# what lets `Base` set-ops / `Dict` / `Set` treat an index and its dual as one leg on a
Expand Down