Complete the single-index set-operation helpers#221
Merged
Conversation
mtfishman
force-pushed
the
mf/tryuniqueind
branch
from
July 14, 2026 19:06
50286d8 to
1c7f495
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 76.07% 76.13% +0.05%
==========================================
Files 29 29
Lines 1693 1697 +4
==========================================
+ Hits 1288 1292 +4
Misses 405 405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fills the single-index index-set helpers out into complete pairs. Each of the three index-set operations now has a plural form, an erroring single form, and a `nothing`-returning single form: - intersection: `commoninds` / `commonind` / `trycommonind` - set difference: `uniqueinds` / `uniqueind` / `tryuniqueind` - symmetric difference: `noncommoninds` / `noncommonind` / `trynoncommonind` This adds the two that were missing, `tryuniqueind` and `noncommonind`, and fixes `trynoncommonind`, which despite its name returned the set difference (`uniqueinds`) rather than the symmetric difference (`noncommoninds`). It now returns the symmetric difference, so `trynoncommonind` is the `nothing`-returning counterpart of `noncommonind` and `tryuniqueind` is the counterpart of `uniqueind`. Code that wants the single index of `a` not in `b` should use `tryuniqueind`.
mtfishman
force-pushed
the
mf/tryuniqueind
branch
from
July 14, 2026 19:14
1c7f495 to
c38cf69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the single-index index-set helpers out into complete pairs. Each of the three index-set operations now has a plural form, an erroring single form, and a
nothing-returning single form:commoninds/commonind/trycommoninduniqueinds/uniqueind/tryuniqueindnoncommoninds/noncommonind/trynoncommonindThis adds the two that were missing,
tryuniqueindandnoncommonind, and fixestrynoncommonind, which despite its name returned the set difference (uniqueinds) rather than the symmetric difference (noncommoninds). It now returns the symmetric difference, sotrynoncommonindis thenothing-returning counterpart ofnoncommonindandtryuniqueindis the counterpart ofuniqueind. Code that wants the single index ofanot inbshould usetryuniqueind.