Handle browser CORS preflight for extract-isdoc and return CORS headers from function responses#3
Draft
Handle browser CORS preflight for extract-isdoc and return CORS headers from function responses#3
extract-isdoc and return CORS headers from function responses#3Conversation
Open
Agent-Logs-Url: https://github.com/ITIXO/MKTestAzureFunction/sessions/01d5bcde-4325-402e-8043-2690252b1ce4 Co-authored-by: miroslavkadera <96105189+miroslavkadera@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ITIXO/MKTestAzureFunction/sessions/01d5bcde-4325-402e-8043-2690252b1ce4 Co-authored-by: miroslavkadera <96105189+miroslavkadera@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CORS error in Azure Function
Handle browser CORS preflight for May 7, 2026
extract-isdoc and return CORS headers from function responses
There was a problem hiding this comment.
Pull request overview
Adds in-function CORS handling for the extract-isdoc HTTP-triggered Azure Function so browser-based clients can successfully complete CORS preflight (OPTIONS) and receive consistent CORS headers across both success and error responses.
Changes:
- Expanded the
extract-isdocHttpTriggerto includeoptionsand short-circuitOPTIONSrequests with204 NoContent. - Added a shared helper to attach CORS headers to preflight, success, and error responses.
- Introduced a unit test to prevent accidental removal of
OPTIONSfrom the trigger definition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ExtractIsdocFunction.cs | Handles OPTIONS preflight and adds CORS headers to all responses from the function. |
| tests/MKTestAzureFunction.Tests/ExtractIsdocFunctionTests.cs | Adds regression test ensuring the trigger includes OPTIONS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+17
| var runMethod = typeof(ExtractIsdocFunction).GetMethod(nameof(ExtractIsdocFunction.Run)); | ||
|
|
||
| Assert.NotNull(runMethod); | ||
|
|
||
| var requestParameter = runMethod!.GetParameters().Single(); | ||
| var triggerAttribute = requestParameter.GetCustomAttribute<HttpTriggerAttribute>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local HTML clients were failing with CORS despite portal-level
*configuration because the function endpoint did not handle preflight (OPTIONS) and did not consistently emit CORS headers from application responses.Preflight support at function endpoint
OPTIONSto theHttpTriggermethods forextract-isdoc.OPTIONSrequests with204 NoContent.Consistent CORS headers from function code
Access-Control-Allow-Origin: *Access-Control-Allow-Methods: POST, OPTIONSAccess-Control-Allow-Headers: Content-Type, Authorization, x-functions-keyFocused regression coverage
OPTIONS, preventing accidental removal of preflight support.