Don't fail import when the gated Llama-2 tokenizer is inaccessible (c4.py)#10
Open
kylefoxaustin wants to merge 1 commit into
Open
Don't fail import when the gated Llama-2 tokenizer is inaccessible (c4.py)#10kylefoxaustin wants to merge 1 commit into
kylefoxaustin wants to merge 1 commit into
Conversation
src/data/c4.py loads the gated meta-llama/Llama-2-7b-hf tokenizer at module-import time. Because src/data/utils.py imports c4, this fires on ANY dataset import, so a user without gated access to that repo cannot train on any dataset (wikitext, shakespeare, ...) -- they hit GatedRepoError / 'trying to access a gated repo'. Guard the load in try/except so import never fails; c4 still uses the tokenizer when actually selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/data/c4.pyloads the gatedmeta-llama/Llama-2-7b-hftokenizer at module-import time (a top-level statement). Becausesrc/data/utils.pyimportsc4, this fires on any dataset import — so a user without gated access to that repo cannot train on any dataset (wikitext, shakespeare, etc.). They hit:Fix
Guard the module-level load in
try/exceptso import never fails.c4still loads/uses the tokenizer when that dataset is actually selected (a user training on c4 is expected to have access).Testing
--dataset wikitextnow imports and trains with no access tometa-llama/Llama-2-7b-hf.