Send veto names with veto configuration update for a central source of truth - #68
Open
rerpha wants to merge 3 commits into
Open
Send veto names with veto configuration update for a central source of truth#68rerpha wants to merge 3 commits into
rerpha wants to merge 3 commits into
Conversation
rerpha
changed the title
Collaborator
Author
|
note to test on ndw1836 you will need to patch over the xml from #67 and edit the register name "vetoes_mask" instead of "veto_mask" |
Comment on lines
+49
to
+55
| # put veto update event on the queue immediately so that vc00 is emitted | ||
| # for downstream consumers even if vetoes don't change | ||
| queue.put( | ||
| VetoesUpdateEvent( | ||
| value=np.asarray(data.vetoes, dtype=np.uint8), done_event=EventWithError() | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
I think we should also do this unconditionally on runstart - just so that it doesn't drop out of Kafka retention or anything silly like that.
Collaborator
Author
There was a problem hiding this comment.
sure - though i'd imagine the vetoConfig topic will have a very large retention rate. regardless, will add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes ISISComputingGroup/DataStreaming#99
CI should pass when the SDT PR is merged and a pypi release is made