Skip to content

Fix race #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tom-Willemsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix race #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions system_tests/tests/keithley_2290.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _insert_reading(class_object, reading):
time.sleep(0.5) # for synchronicity help


class Status(object):
class Status:
ON = "ON"
OFF = "OFF"

Expand Down Expand Up @@ -107,9 +107,9 @@ def test_WHEN_setting_volt_OFF(self):
)

def test_WHEN_setting_trip_reset_mode(self):
Automatic = "AUTO"
automatic = "AUTO"
self.ca.assert_setting_setpoint_sets_readback(
Automatic, "TRIP_RESET_MODE", expected_value=Automatic, expected_alarm="NO_ALARM"
automatic, "TRIP_RESET_MODE", expected_value=automatic, expected_alarm="NO_ALARM"
)

@skip_if_recsim("no volt_limit side effect recsim")
Expand Down Expand Up @@ -145,10 +145,8 @@ def test_WHEN_setting_volt_beyond_volt_limit(self):
self.ca.assert_setting_setpoint_sets_readback(
volt_setpoint, "VOLT", expected_value=0, expected_alarm="NO_ALARM"
)
self.ca.set_pv_value("ERROR.PROC", 1) # Force processing so we don't have to wait 1 second
self.ca.assert_that_pv_alarm_is("EXECUTION_ERROR", self.ca.Alarms.MAJOR)
self.ca.set_pv_value("EXECUTION_ERROR.PROC", 1)
self.ca.set_pv_value("STATUS.PROC", 1) # Force processing so we don't have to wait 1 second
self.ca.assert_that_pv_alarm_is("VOLT_TRIPPED", self.ca.Alarms.NONE)

@skip_if_recsim("no backdoor in recsim")
Expand Down