内容検索の処理です#11
Open
TTTTk84 wants to merge 3 commits into
Open
Conversation
isshun226
requested changes
Nov 9, 2019
Comment on lines
+4
to
+9
| let value_input = document.getElementById("value_input"); | ||
|
|
||
| //todoリストに入っている分ループ | ||
| for (let i = 0; i < taskNumber; i++) { | ||
| //class_name[1]に内容 [2]にタグ名 | ||
| let class_name = document.getElementsByClassName('"' + i + '"'); |
Collaborator
There was a problem hiding this comment.
letは再代入する時のみ使用するようにしましょう
constにしておくことで意図せぬ代入を防ぐことができるのでより安全です。
var,let,constの違いを理解した上で使えるととても良いです
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.