Skip to content

Removing deprecated Meta class#12418

Merged
landreev merged 2 commits into
developfrom
12417-remove-meta-class
Jun 1, 2026
Merged

Removing deprecated Meta class#12418
landreev merged 2 commits into
developfrom
12417-remove-meta-class

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

@stevenwinship stevenwinship commented May 29, 2026

What this PR does / why we need it: Meta class is not needed

Which issue(s) this PR closes:#12417

Special notes for your reviewer:

Suggestions on how to test this: call GET /api/meta/datafile/13962692

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this May 29, 2026
@github-actions github-actions Bot added FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) Original size: 3 labels May 29, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project May 29, 2026
@stevenwinship stevenwinship added this to the 6.11 milestone May 29, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 29, 2026

Coverage Status

coverage: 24.954% (+0.009%) from 24.945% — 12417-remove-meta-class into develop

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Test Results

397 tests  ±0   382 ✅ ±0   33m 5s ⏱️ +7s
 53 suites ±0    15 💤 ±0 
 53 files   ±0     0 ❌ ±0 

Results for commit 080a81b. ± Comparison against base commit 217d430.

♻️ This comment has been updated with latest results.

@stevenwinship stevenwinship force-pushed the 12417-remove-meta-class branch from 1a6f8a3 to bf7e049 Compare May 29, 2026 21:08
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2026
@stevenwinship stevenwinship removed their assignment May 29, 2026
@stevenwinship stevenwinship requested a review from landreev May 29, 2026 21:25
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please also remove this method with the path hard-coded:
https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/DatasetPage.java#L4884-L4889
Aside from that, will approve once Jenkins finishes; probably first thing next week.

@stevenwinship stevenwinship force-pushed the 12417-remove-meta-class branch from bf7e049 to beb49c6 Compare June 1, 2026 14:02
@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12417-remove-meta-class
ghcr.io/gdcc/configbaker:12417-remove-meta-class

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@landreev landreev moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 1, 2026
@landreev landreev merged commit e46a251 into develop Jun 1, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 1, 2026
@landreev landreev deleted the 12417-remove-meta-class branch June 1, 2026 19:22
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) Original size: 3

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Remove Meta Class

4 participants