Local reviews#12327
Closed
pdurbin wants to merge 5 commits into
Closed
Conversation
github-actions
Bot
added
FY26 Sprint 21
|
coverage: 24.874% (-0.01%) from 24.887% — 12313-local-reviews into develop |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
force-pushed
the
12313-local-reviews
branch
from
b703d40 to
993f086
Compare
This comment has been minimized.
This comment has been minimized.
pdurbin
force-pushed
the
12313-local-reviews
branch
from
993f086 to
7b98854
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Hi @pdurbin, this looks good! The only comment I have is that it would be good to include in the documentation the expected data in the response. I reviewed the API endpoint itself, I didn't focus the implementation details. I'm assuming you want someone else to review that?
pdurbin
force-pushed
the
12313-local-reviews
branch
from
7b98854 to
36c7b86
Compare
Member
Author
|
I'm planning on making a new PR to replace this one. |
Member
Author
|
Closing in favor of this PR which closes two issues instead of one: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to support local reviews, which is when a review dataset points at a regular dataset and both are in the same installation of Dataverse.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Create a dataset like this:
Then, create a review dataset that points to the dataset like this:
Then try the new "list reviews" API endpoint.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Preview at https://dataverse-guide--12327.org.readthedocs.build/en/12327/api/native-api.html#list-reviews
In the image below (source) ReviewDataset2 is a local review: