feat: Improve TURN server configuration safety and error handling - #166
Open
bromiesTM wants to merge 1 commit into
Open
feat: Improve TURN server configuration safety and error handling#166bromiesTM wants to merge 1 commit into
bromiesTM wants to merge 1 commit into
Conversation
Abort early if retrieving the current TURN server list fails, preventing spurious "already exists" errors when proceeding blindly. Remove error suppression that masked real configuration problems. Extract jq parsing into a variable for better readability. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TURN server configuration in configure.sh by failing fast when the current TURN server state cannot be reliably determined, and by removing prior error suppression so real configuration problems surface instead of causing misleading downstream errors.
Changes:
- Abort TURN configuration early if
talk:turn:listfails, preventing add attempts against an unknown state. - Stop suppressing
talk:turn:adderrors so TURN configuration failures are reported as real errors. - Extract TURN list parsing into an intermediate variable for readability and reuse.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+531
to
+532
| _turn_entries=$(echo "${turnList}" | jq -r '.[] | [.schemes, .server, .protocols] | @tsv' 2>/dev/null) | ||
| if [ -n "${_turn_entries}" ]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort early if retrieving the current TURN server list fails, preventing spurious "already exists" errors when proceeding blindly. Remove error suppression that masked real configuration problems. Extract jq parsing into a variable for better readability.