feat(HDNEXT-1010): intercept file-request send-email via IONOS mailer API

[printminion-co]

Summary

Replaces ShareCreatedEventListener with BeforeShareMailSentEventListener — the single handler for all share-by-link email delivery via the IONOS internal mail API.

What changed

• New: BeforeShareMailSentEventListener handles BeforeShareMailSentEvent fired by ShareByMailProvider.sendEmail() (nc-server PR#262). Calls markMailHandled() unconditionally in every TYPE_EMAIL code path, suppressing native Nextcloud SMTP.
• Retired: ShareCreatedEventListener caused double-sends — it called the IONOS API at ShareCreatedEvent time while native SMTP also ran via sendMailNotification().
• Simplified: listener constructor drops IUserManager and IURLGenerator — the event now carries pre-computed mailData (senderUserId, fileName, resourceUrl, note, expiration).
• psalm.xml: adds ../../apps/sharebymail/lib/Event as extra files so psalm resolves the event class.
• tests/stubs/: provides BeforeShareMailSentEvent stub for CI environments without nc-server.

markMailHandled() coverage

Code path	markMailHandled() called?
Non-TYPE_EMAIL share	no — native SMTP still runs
TYPE_EMAIL, empty recipients	yes — suppressed + warning logged
TYPE_EMAIL, missing senderUserId in mailData	yes — suppressed + error logged
TYPE_EMAIL, successful IONOS send	yes — suppressed
TYPE_EMAIL, IONOS send throws	propagates as exception (native send also skipped)

Related PRs

• IONOS(sharebymail): add BeforeShare*MailSentEvent dispatched before each mail send (HDNEXT-1010) nc-server#262 — nc-server event classes and dispatch wiring (must merge first)

Test plan

• composer test:unit — 14/14 pass
• composer cs:fix — no changes
• composer psalm — no errors
• E2E: regular share by email → IONOS API called once; no double-send
• E2E: file request send-email → IONOS API called; no native SMTP

[Copilot]

Pull request overview

Adds support for routing “send-email” (share email resend) requests through the IONOS mailer API by introducing a new listener for BeforeShareMailNotifiedEvent, while also hardening existing share-created handling against empty recipients to prevent IONOS API errors.

Changes:

• Add BeforeShareMailNotifiedEventListener to intercept email resend events and forward them to IonosMailerService.
• Add an early-return guard in ShareCreatedEventListener when getSharedWith() is empty.
• Extend unit tests and test bootstrap to support the new event (via stub fallback) and validate listener registrations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
lib/Listener/ShareCreatedEventListener.php	Adds empty-recipient guard before sending to the mailer service.
lib/Listener/BeforeShareMailNotifiedEventListener.php	New listener for resend/send-email flow, sends share-by-link payload via IONOS mailer.
lib/AppInfo/Application.php	Registers the new listener in the app bootstrap.
tests/Listener/ShareCreatedEventListenerTest.php	Adds unit test for empty-recipient guard behavior.
tests/Listener/BeforeShareMailNotifiedEventListenerTest.php	New unit tests for the new listener’s behavior and error paths.
tests/stubs/BeforeShareMailNotifiedEvent.php	Provides test-only fallback event class when not available in the runtime.
tests/bootstrap.php	Loads the fallback event stub conditionally for unit tests.
tests/AppInfo/ApplicationTest.php	Updates expectations to verify both event listener registrations.
psalm.xml	Adds the new event stub file to Psalm stubs to satisfy static analysis.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

[tanyaka]

Code review

No issues found. Checked for bugs, event registration correctness, listener logic (TYPE_EMAIL guard, markMailHandled ordering, empty-recipients path), test coverage, and consistency with nc-server PR #262.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[tanyaka]

Review OK.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 16 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

lib/Service/IonosMailerService.php:80

• IonosMailerService::send() catches and swallows exceptions from processShareByLinkEvent(). With the new listener calling markMailHandled() to suppress native SMTP, this results in a silent mail loss: the share mail is neither delivered via IONOS nor via SMTP, and no exception propagates to the caller (also contradicts the listener docstring/PR description about propagating failures). Consider rethrowing (or returning a success flag) so the caller can fail the request and/or trigger retries; update unit tests accordingly.

		if ($eventName === BeforeShareMailSentEventListener::EVENT_NAME_SHARE_BY_LINK) {
			$message = new ShareMessageByLink($variables);
			try {
				$this->logger->debug('Send message to mailer service', ['event' => $eventName, 'variables' => $variables]);
				$apiInstance->processShareByLinkEvent(self::BRAND, $message);
			} catch (Exception $e) {
				$this->logger->error('Exception when calling EventAPIApi->processShareByLinkEvent', ['exception' => $e]);
			}