refactor: Remove nc-ionos-theme build configuration - #144
Open
bromiesTM wants to merge 1 commit into
Open
Conversation
4 tasks
bromiesTM
force-pushed
the
kh/dev/add-simplenavigation-v33
branch
from
August 4, 2026 08:04
5f7854d to
e15d981
Compare
There was a problem hiding this comment.
Pull request overview
Removes the dedicated build path for the nc-ionos-theme theme and shifts app build categorization by adding simplenavigation to the standard custom NPM app pipeline.
Changes:
- Removed
nc-ionos-themefromSPECIAL_BUILD_APPSand deleted its dedicatedbuild_nc-ionos-theme_apptarget. - Added
simplenavigationtoCUSTOM_NPM_APPSso it uses the dynamicbuild_%_apprule. - Removed
nc-ionos-theme-specific exclusions from thezip_dependenciespackaging step.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
printminion-co
requested changes
Aug 12, 2026
printminion-co
left a comment
printminion-co
left a comment
Contributor
There was a problem hiding this comment.
lets use ionos-dev-v33 branch in order not to break the master vor v31 and v32
Remove nc-ionos-theme from SPECIAL_BUILD_APPS and its dedicated build target. Add simplenavigation to CUSTOM_NPM_APPS and clean up related zip exclusion rules. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/add-simplenavigation-v33
branch
from
August 13, 2026 05:54
e15d981 to
b31fbdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nc-ionos-theme from SPECIAL_BUILD_APPS and its dedicated build target. Add simplenavigation to CUSTOM_NPM_APPS and clean up related zip exclusion rules.